Page MenuHomePhabricator

Translate "All Day" events into the viewer's time
ClosedPublic

Authored by epriestley on May 8 2015, 1:27 AM.
Tags
None
Referenced Files
F19507208: D12765.diff
Fri, Jan 9, 6:32 PM
F19507194: D12765.diff
Fri, Jan 9, 6:29 PM
F19101139: D12765.id.diff
Dec 5 2025, 1:53 AM
F19019045: D12765.id.diff
Nov 23 2025, 1:19 PM
F19018004: D12765.diff
Nov 23 2025, 9:59 AM
F18979782: D12765.id.diff
Nov 16 2025, 10:55 PM
F18821748: D12765.id.diff
Oct 23 2025, 1:35 AM
F18815982: D12765.diff
Oct 21 2025, 4:31 AM
Subscribers

Details

Summary

Ref T8021.

  • When "All Day" events are loaded, convert them into the viewer's time.
  • When "All Day" events are saved, convert them into a +24 hour range.
Test Plan
  • Created and updated "All Day" events.
  • Created and updated normal events.
  • Changed timezones, edited and viewed "All Day" events and normal events.
  • In all cases, "All Day" events appeared to be 12:00AM - 11:59:59PM to the viewer, on the correct day.
  • Normal events shifted around properly according to timezones.

Diff Detail

Repository
rP Phabricator
Branch
alldayevent
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5850
Build 5870: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Translate "All Day" events into the viewer's time.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: lpriestley.
lpriestley edited edge metadata.
This revision is now accepted and ready to land.May 8 2015, 1:57 AM
This revision was automatically updated to reflect the committed changes.