Page MenuHomePhabricator
Differential D12752

Don't require memes to be at the end of a line
ClosedPublic
Actions

Authored by epriestley on May 7 2015, 5:37 PM.
Tags
None
Referenced Files
F17841364: D12752.diff
Sat, Jul 26, 10:20 PM
F17826949: D12752.id.diff
Sat, Jul 26, 7:47 AM
F17822729: D12752.id30651.diff
Sat, Jul 26, 3:59 AM
F17809747: D12752.diff
Fri, Jul 25, 5:02 PM
Unknown Object (File)
Jun 18 2025, 11:04 PM
Unknown Object (File)
Jun 18 2025, 7:26 AM
Unknown Object (File)
Jun 17 2025, 7:39 PM
Unknown Object (File)
Apr 25 2025, 5:41 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7893: placing two memes side by side results in blank comment
Commits
Restricted Diffusion Commit
rP29d34e8f62f0: Don't require memes to be at the end of a line
Summary

Fixes T7893.

Test Plan

Screen Shot 2015-05-07 at 10.37.07 AM.png (1×704 px, 466 KB)

Diff Detail

Repository
rP Phabricator
Branch
mem1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5830
Build 5850: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30645.May 7 2015, 5:37 PM
epriestley retitled this revision from to Don't require memes to be at the end of a line.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7893: placing two memes side by side results in blank comment.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 7 2015, 5:37 PM
btrahan accepted this revision.May 7 2015, 5:49 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 7 2015, 5:49 PM
Closed by commit rP29d34e8f62f0: Don't require memes to be at the end of a line (authored by epriestley, committed by epriestley). · Explain WhyMay 7 2015, 6:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
macro/
markup/
2 lines

Diff 30645

View Options

src/applications/macro/markup/PhabricatorMemeRemarkupRule.php

Loading...
Phabricator · Built by Phacility