Page MenuHomePhabricator
Differential D12742

First stab at Calendar day view sidebar
ClosedPublic
Actions

Authored by lpriestley on May 7 2015, 1:21 AM.
Tags
None
Referenced Files
F13235918: D12742.id30616.diff
Tue, May 21, 7:06 AM
F13235917: D12742.id30618.diff
Tue, May 21, 7:06 AM
F13235916: D12742.id30617.diff
Tue, May 21, 7:06 AM
F13229471: D12742.id.diff
Mon, May 20, 4:42 PM
F13200062: D12742.diff
Mon, May 13, 10:15 PM
F13184122: D12742.diff
Fri, May 10, 3:32 PM
F13183090: D12742.id30616.diff
Fri, May 10, 6:56 AM
Unknown Object (File)
Sun, May 5, 5:45 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4393: Implement "Daily/Weekly" Calendar Mock
Commits
Restricted Diffusion Commit
rP7fd401d0e023: First stab at Calendar day view sidebar
Summary

Ref T4393, First stab at Calendar day view sidebar

Test Plan

Open Calendar day view, sidebar should show today and the next 6 days, empty or not.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 30616.May 7 2015, 1:21 AM
lpriestley retitled this revision from to First stab at Calendar day view sidebar.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T4393: Implement "Daily/Weekly" Calendar Mock.
Herald added reviewers: chad, Blessed Reviewers. · View Herald TranscriptMay 7 2015, 1:21 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
lpriestley updated this revision to Diff 30617.May 7 2015, 1:21 AM
lpriestley edited edge metadata.

Updating celerity

chad edited edge metadata.May 7 2015, 1:27 AM

This_thread_is_worthless_without_pictures_zps73b36e33.jpg (255×332 px, 19 KB)

lpriestley added a comment.May 7 2015, 1:33 AM

@chad here you go!

Screen Shot 2015-05-06 at 6.32.03 PM.png (805×1 px, 104 KB)

epriestley accepted this revision.May 7 2015, 1:36 AM
epriestley edited edge metadata.
epriestley added inline comments.
src/view/phui/calendar/PHUICalendarDayView.php
202–204

When you only have one node, you can just pass $name instead of array($name).

206–243

Same for three of these four.

263

pht()

265

pht()

This revision is now accepted and ready to land.May 7 2015, 1:36 AM
lpriestley updated this revision to Diff 30618.May 7 2015, 1:40 AM
lpriestley marked 4 inline comments as done.
lpriestley edited edge metadata.

Cleaning up phutil_tag calls and some missed pht opportunities

Closed by commit rP7fd401d0e023: First stab at Calendar day view sidebar (authored by lpriestley, committed by lpriestley). · Explain WhyMay 7 2015, 1:41 AM
This revision was automatically updated to reflect the committed changes.
chad added a comment.May 7 2015, 1:43 AM

For the sidebar, there should already be a PHUI library for that, PHUICalendarListView or something?

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
calendar/
query/
4 lines
infrastructure/
time/
11 lines
view/
phui/
calendar/
148 lines
webroot/
rsrc/
css/
phui/
calendar/
23 lines

Diff 30619

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...
View Options

src/infrastructure/time/PhabricatorTime.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarDayView.php

Loading...
View Options

webroot/rsrc/css/phui/calendar/phui-calendar-day.css

Loading...
Phabricator · Built by Phacility