Quicksand and global drag and drop - install quicksand listener on event only
ClosedPublic
Actions

Authored by btrahan on May 6 2015, 7:18 PM.

Details

Reviewers

Maniphest Tasks

Commits

Restricted Diffusion Commit
rP97d011d98588: Quicksand and global drag and drop - install quicksand listener on event only

Summary

noticed this while doing some other work. didn't really break anything before but no need to install this listener every time we load the global drag and drop behavior; just the once works fine.

Test Plan

home -> profile -> back to home and drag and drop still worked

Diff Detail

Repository

rP Phabricator

Branch

randomsauce

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5805
Build 5824: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 30610.May 6 2015, 7:18 PM

btrahan retitled this revision from to Quicksand and global drag and drop - install quicksand listener on event only.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 6 2015, 7:18 PM

epriestley accepted this revision.May 6 2015, 7:39 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 6 2015, 7:39 PM

Closed by commit rP97d011d98588: Quicksand and global drag and drop - install quicksand listener on event only (authored by btrahan, committed by btrahan). · Explain WhyMay 6 2015, 7:59 PM

This revision was automatically updated to reflect the committed changes.

btrahan added a task: T7573: Ship Quicksand.May 6 2015, 7:59 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

8 lines

webroot/

rsrc/

js/

core/

behavior-global-drag-and-drop.js

19 lines

Diff 30610

View Options

resources/celerity/map.php