Page MenuHomePhabricator
Differential D12727

Quicksand + Pholio - make mock view work
ClosedPublic
Actions

Authored by btrahan on May 5 2015, 10:41 PM.
Tags
None
Referenced Files
F15475345: D12727.diff
Sun, Apr 6, 6:41 PM
F15466522: D12727.id.diff
Thu, Apr 3, 6:28 AM
F15463885: D12727.diff
Wed, Apr 2, 4:16 AM
F15456101: D12727.diff
Sun, Mar 30, 7:03 AM
F15449570: D12727.id30578.diff
Fri, Mar 28, 10:59 AM
F15405300: D12727.id30588.diff
Tue, Mar 18, 11:02 AM
F15387293: D12727.id30587.diff
Sat, Mar 15, 2:10 AM
F15370002: D12727.diff
Wed, Mar 12, 9:00 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T8036: Pholio images don't switch in Quicksand
Commits
Restricted Diffusion Commit
rP179948e23273: Quicksand + Pholio - make mock view work
Summary

Ref T8036. This was a lot of JS to fiddle with.

Test Plan

viewed a mock with durable column open, clicked back to pholio home, then clicked back to mock and was able to switch images. clicked to profile and then hit browser back and was still able to switch images.

Diff Detail

Repository
rP Phabricator
Branch
T8036
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5784
Build 5803: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 30578.May 5 2015, 10:41 PM
btrahan added a task: T8036: Pholio images don't switch in Quicksand.
btrahan retitled this revision from to Quicksand + Pholio - make mock view work.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 5 2015, 10:41 PM
epriestley accepted this revision.May 5 2015, 10:52 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 5 2015, 10:52 PM
btrahan updated this revision to Diff 30587.May 5 2015, 11:18 PM
btrahan edited edge metadata.

celery

Closed by commit rP179948e23273: Quicksand + Pholio - make mock view work (authored by btrahan, committed by btrahan). · Explain WhyMay 5 2015, 11:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
32 lines
src/
applications/
pholio/
controller/
6 lines
view/
74 lines
webroot/
rsrc/
js/
application/
pholio/
633 lines

Diff 30578

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/pholio/controller/PholioMockViewController.php

Loading...
View Options

src/applications/pholio/view/PholioMockImagesView.php

Loading...
View Options

webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js

Loading...
Phabricator · Built by Phacility