Ref T4393, Calendar day view should have forward/back controls to scroll through days
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T4393: Implement "Daily/Weekly" Calendar Mock
- Commits
- Restricted Diffusion Commit
rP14af40afa09e: Calendar day view should have forward/back controls to scroll through days
Open day view on first or last day of the month, scrolling backwards or forwards through days should correctly calculate the date of the next day and the previous day and correctly find events.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- calendardayviewforwardbackcontrols
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 5775 Build 5794: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php | ||
|---|---|---|
| 405–448 | Now that calendarDay is in full use, we should merge these two nearly identical functions into one that does all three parts. | |
| src/view/phui/calendar/PHUICalendarDayView.php | ||
| 256 | At first, I thought this would return a list of days. Maybe getNumberOfDaysInMonth()? | |
| 279 | You might be able to simplify this logic by doing: $prev = new DateTime("{$year}-{$month}-{$day}", $zone);
$prev->modify('-1 day');
return array(
$prev->format('Y'),
$prev->fomat('m'),
$prev->format('d'),
);I'm only like 80% sure that actually works. | |