Improve passphrase.query
ClosedPublic
Actions

Authored by epriestley on May 5 2015, 12:40 PM.

Details

Reviewers

Maniphest Tasks

T8070: Add Description to returned fields for passphrase.query in Conduit
T8071: Conduit crashes when listing destroyed credentials with needSecret=true in passphrase.query

Commits

Restricted Diffusion Commit
rPa5402c46b2b9: Improve passphrase.query

Summary

Fixes T8070. Fixes T8071. Modernizes passphrase.query to support "order".

Test Plan

Saw description in results.
Queried for destroyed credentials with "needSecrets=true".
Used "order".

Diff Detail

Repository

rP Phabricator

Branch

pphrase1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5764
Build 5783: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30550.May 5 2015, 12:40 PM

epriestley retitled this revision from to Improve passphrase.query.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T8071: Conduit crashes when listing destroyed credentials with needSecret=true in passphrase.query, T8070: Add Description to returned fields for passphrase.query in Conduit.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 5 2015, 12:40 PM

Thanks for being so quick!

btrahan accepted this revision.May 5 2015, 5:23 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 5 2015, 5:23 PM

Closed by commit rPa5402c46b2b9: Improve passphrase.query (authored by epriestley, committed by epriestley). · Explain WhyMay 5 2015, 10:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

passphrase/

conduit/

PassphraseQueryConduitAPIMethod.php

34 lines

Diff 30550

View Options

src/applications/passphrase/conduit/PassphraseQueryConduitAPIMethod.php

Improve passphrase.queryClosedPublicActions