Page MenuHomePhabricator
Differential D12711

Implement day view event clustering so that overlapping events can share latitude
ClosedPublic
Actions

Authored by lpriestley on May 5 2015, 4:09 AM.
Tags
None
Referenced Files
F14352674: D12711.diff
Thu, Dec 19, 2:36 PM
Unknown Object (File)
Wed, Dec 11, 10:05 PM
Unknown Object (File)
Sat, Dec 7, 5:12 AM
Unknown Object (File)
Sun, Dec 1, 6:59 AM
Unknown Object (File)
Sat, Nov 30, 5:44 AM
Unknown Object (File)
Wed, Nov 27, 7:47 AM
Unknown Object (File)
Sat, Nov 23, 4:42 AM
Unknown Object (File)
Nov 19 2024, 12:50 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4393: Implement "Daily/Weekly" Calendar Mock
Commits
Restricted Diffusion Commit
rP0aea2cb1c0c7: Implement day view event clustering so that overlapping events can share…
Summary

Ref T4393, Implement day view event clustering so that overlapping events can share latitude.

Test Plan

Open day view in Calendar search query on a day with overlapping events. Overlapping events should be displayed side by side when possible, and should be layed out as a staircase when overlapping times.

Diff Detail

Repository
rP Phabricator
Branch
calendardayviewclustering
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5755
Build 5774: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30526.May 5 2015, 4:09 AM
lpriestley retitled this revision from to Implement day view event clustering so that overlapping events can share latitude.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T4393: Implement "Daily/Weekly" Calendar Mock.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 5 2015, 4:09 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.May 5 2015, 4:12 AM
epriestley edited edge metadata.

One inline.

src/view/phui/calendar/PHUICalendarDayView.php
246–253

This can be removed now, we don't actually need it anymore since we switched to event IDs.

This revision is now accepted and ready to land.May 5 2015, 4:12 AM
lpriestley updated this revision to Diff 30527.May 5 2015, 4:22 AM
lpriestley edited edge metadata.

Removing unused helper method

lpriestley marked an inline comment as done.May 5 2015, 4:22 AM
Closed by commit rP0aea2cb1c0c7: Implement day view event clustering so that overlapping events can share… (authored by lpriestley, committed by lpriestley). · Explain WhyMay 5 2015, 4:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
query/
1 line
view/
10 lines
view/
phui/
calendar/
115 lines

Diff 30527

View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...
View Options

src/applications/calendar/view/AphrontCalendarDayEventView.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarDayView.php

Loading...
Phabricator · Built by Phacility