Page MenuHomePhabricator
Differential D12705

Highlight cell when jumping to an inline comment
ClosedPublic
Actions

Authored by epriestley on May 4 2015, 7:16 PM.
Tags
None
Referenced Files
F15384166: D12705.id.diff
Fri, Mar 14, 6:59 PM
F15382144: D12705.id30506.diff
Fri, Mar 14, 10:56 AM
F15375789: D12705.diff
Thu, Mar 13, 12:14 AM
Unknown Object (File)
Sun, Feb 23, 10:02 PM
Unknown Object (File)
Thu, Feb 13, 6:42 PM
Unknown Object (File)
Feb 9 2025, 6:29 PM
Unknown Object (File)
Feb 8 2025, 4:17 AM
Unknown Object (File)
Feb 8 2025, 4:17 AM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Maniphest Tasks
T8061: When following an anchor to an inline comment, highlight the comment
Commits
Restricted Diffusion Commit
rP9c7d1b0b90b5: Highlight cell when jumping to an inline comment
Summary

Fixes T8061.

Test Plan

Screen Shot 2015-05-04 at 12.15.01 PM.png (284×852 px, 29 KB)

Diff Detail

Repository
rP Phabricator
Branch
hcomment
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5745
Build 5764: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30505.May 4 2015, 7:16 PM
epriestley retitled this revision from to Highlight cell when jumping to an inline comment.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T8061: When following an anchor to an inline comment, highlight the comment.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 4 2015, 7:16 PM
chad accepted this revision.May 4 2015, 7:20 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 4 2015, 7:20 PM
Closed by commit rP9c7d1b0b90b5: Highlight cell when jumping to an inline comment (authored by epriestley, committed by epriestley). · Explain WhyMay 4 2015, 7:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
infrastructure/
diff/
view/
19 lines
4 lines
1 line
2 lines
webroot/
rsrc/
css/
application/
differential/
5 lines
4 lines

Diff 30505

View Options

resources/celerity/map.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentView.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffOneUpInlineCommentRowScaffold.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffTwoUpInlineCommentRowScaffold.php

Loading...
View Options

webroot/rsrc/css/application/differential/phui-inline-comment.css

Loading...
View Options

webroot/rsrc/css/application/differential/revision-comment.css

Loading...
Phabricator · Built by Phacility