Ref T6930. Add subprocess sampling/labeling.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T6930: Build Multimeter, a "why is Phabricator slow?" toolset
- Commits
- Restricted Diffusion Commit
rPbee4dc7d5316: Support sampling subprocess execution in Multimeter
(This table includes some buggy test labels.)
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- mm6
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 5701 Build 5720: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| src/applications/multimeter/data/MultimeterControl.php | ||
|---|---|---|
| 236–239 | Seems like a good idea for now, though I predict we'll at least need to grow this list a bit over time. | |
| src/applications/multimeter/data/MultimeterControl.php | ||
|---|---|---|
| 236–239 | maybe we just end up with some conf dict that gets merged in? we can then have admins mess with the conf if we're looking for specific performance issues to get sampled in all their glory. | |
Comment Actions
Since we don't actually use the table until the very end of the request, we could let third-party applications do this sort of thing:
$multimeter = ... $multimeter->addCommandAbbreviationConfig(...);
...once we run into it in the wild.