Page MenuHomePhabricator
Differential D12656

Calendar event edit view should validate that start time preceeds end time
ClosedPublic
Actions

Authored by lpriestley on May 2 2015, 2:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 7:43 PM
Unknown Object (File)
Sun, Dec 15, 5:42 PM
Unknown Object (File)
Wed, Dec 11, 5:23 AM
Unknown Object (File)
Thu, Dec 5, 9:32 PM
Unknown Object (File)
Thu, Dec 5, 2:14 AM
Unknown Object (File)
Wed, Dec 4, 9:13 PM
Unknown Object (File)
Wed, Dec 4, 5:45 AM
Unknown Object (File)
Sat, Nov 30, 1:18 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8023: Calendar event edits should gracefully handle an "end time before start time" error.
Commits
Restricted Diffusion Commit
rP25b1fb1de274: Calendar event edit view should validate that start time preceeds end time
Summary

Closes T8023, Calendar event edit view should validate that start time preceeds end time .

Test Plan

Create Calendar event, add details, make end time be earlier than start time, try to save, get error, make sure all previously entered details are populated correctly.

Diff Detail

Repository
rP Phabricator
Branch
calendareventvalidatestartenddate
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5675
Build 5694: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30400.May 2 2015, 2:03 PM
lpriestley retitled this revision from to Calendar event edit view should validate that start time preceeds end time.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8023: Calendar event edits should gracefully handle an "end time before start time" error..
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 2 2015, 2:03 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.May 2 2015, 5:15 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 2 2015, 5:15 PM
Closed by commit rP25b1fb1de274: Calendar event edit view should validate that start time preceeds end time (authored by lpriestley, committed by lpriestley). · Explain WhyMay 2 2015, 10:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30400

View Options

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php

Loading...
View Options

src/applications/calendar/exception/PhabricatorCalendarEventInvalidEpochException.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
View Options

src/applications/people/conduit/UserAddStatusConduitAPIMethod.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility