Differential D12655

Compute average costs more correctly in Multimeter
ClosedPublic
Actions

Authored by epriestley on May 2 2015, 11:45 AM.

Details

Reviewers

btrahan

Maniphest Tasks

T6930: Build Multimeter, a "why is Phabricator slow?" toolset

Commits

Restricted Diffusion Commit
rPe6e0df6aff4c: Compute average costs more correctly in Multimeter

Summary

Ref T6930. We were dividing total cost by number of samples, but should more accurately divide it by the sum of the sample rates. This produces a more meaningful number.

Test Plan

Saw a more meaningful number in the UI.

Diff Detail

Repository

rP Phabricator

Branch

mm5

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5674
Build 5693: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30399.May 2 2015, 11:45 AM

epriestley retitled this revision from to Compute average costs more correctly in Multimeter.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T6930: Build Multimeter, a "why is Phabricator slow?" toolset.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 2 2015, 11:45 AM

btrahan accepted this revision.May 4 2015, 4:43 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 4 2015, 4:43 PM

Closed by commit rPe6e0df6aff4c: Compute average costs more correctly in Multimeter (authored by epriestley, committed by epriestley). · Explain WhyMay 4 2015, 5:04 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

multimeter/

controller/

MultimeterSampleController.php

7 lines

Diff 30399

View Options

src/applications/multimeter/controller/MultimeterSampleController.php

Compute average costs more correctly in MultimeterClosedPublicActions