Page MenuHomePhabricator
Differential D12647

Fix datepicker to show correct error messages on Calendar event edit view
ClosedPublic
Actions

Authored by lpriestley on May 1 2015, 10:20 PM.
Tags
None
Referenced Files
F14489787: D12647.diff
Thu, Jan 2, 12:45 AM
F14487574: D12647.diff
Wed, Jan 1, 1:24 AM
Unknown Object (File)
Sat, Dec 14, 12:18 PM
Unknown Object (File)
Thu, Dec 5, 12:13 PM
Unknown Object (File)
Thu, Dec 5, 2:30 AM
Unknown Object (File)
Wed, Dec 4, 2:40 PM
Unknown Object (File)
Dec 1 2024, 1:48 AM
Unknown Object (File)
Nov 30 2024, 7:42 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8025: Calendar event form errors should not erase newly selected dates.
T8024: Update Calendar event date selection controls
Commits
Restricted Diffusion Commit
rPbd0eef359471: Fix datepicker to show correct error messages on Calendar event edit view
Summary

Ref T8024, Fix datepicker to show correct error messages on Calendar event edit view.

Test Plan

Edit Calendar event, set blank title, and valid new end time, error page should correctly point out invalid title, but reflec the updated time.

Diff Detail

Repository
rP Phabricator
Branch
calendareventdatepicker
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5658
Build 5677: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30380.May 1 2015, 10:20 PM
lpriestley retitled this revision from to Fix datepicker to show correct error messages on Calendar event edit view.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8024: Update Calendar event date selection controls.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 1 2015, 10:20 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.May 1 2015, 10:40 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
74

No longer used.

164–172

Consider:

$value = $ex->getShortMessage(
  $param);
This revision is now accepted and ready to land.May 1 2015, 10:40 PM
lpriestley updated this revision to Diff 30382.May 1 2015, 11:06 PM
lpriestley edited edge metadata.

Lint cleanup

lpriestley marked 2 inline comments as done.May 1 2015, 11:07 PM
Closed by commit rPbd0eef359471: Fix datepicker to show correct error messages on Calendar event edit view (authored by lpriestley, committed by lpriestley). · Explain WhyMay 1 2015, 11:08 PM
This revision was automatically updated to reflect the committed changes.
lpriestley mentioned this in T8025: Calendar event form errors should not erase newly selected dates..May 7 2015, 2:39 AM
lpriestley added a task: T8025: Calendar event form errors should not erase newly selected dates..

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
calendar/
controller/
186 lines
editor/
18 lines
view/
form/
control/
13 lines
93 lines

Diff 30380

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventEditController.php

Loading...
View Options

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php

Loading...
View Options

src/view/form/control/AphrontFormDateControl.php

Loading...
View Options

src/view/form/control/AphrontFormDateControlValue.php

Loading...
Phabricator · Built by Phacility