Fix iconNav in Windows
ClosedPublic
Actions

Authored by chad on May 1 2015, 7:29 PM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T8012: IconNav seems to have fun scrollbar in IE

Commits

Restricted Diffusion Commit
rPd25245414c60: Fix iconNav in Windows

Summary

Fixes T8012. The line height here with the stock Segoe font are causing some overflow issues. I guess Segoe bleeds out of the line-height bounding box.

Test Plan

Test Chrome, IE on Windows, Chrome on Mac. Seems spiffy to me.

Diff Detail

Repository

rP Phabricator

Branch

line-height

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5653
Build 5672: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 30369.May 1 2015, 7:29 PM

chad retitled this revision from to Fix iconNav in Windows.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T8012: IconNav seems to have fun scrollbar in IE.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 1 2015, 7:29 PM

epriestley accepted this revision.May 1 2015, 8:07 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 1 2015, 8:07 PM

Closed by commit rPd25245414c60: Fix iconNav in Windows (authored by chad, committed by chad). · Explain WhyMay 1 2015, 8:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

layout/

phabricator-side-menu-view.css

2 lines

Diff 30369

View Options

resources/celerity/map.php