Page MenuHomePhabricator
Differential D12641

Minor tweaks to inline comments
ClosedPublic
Actions

Authored by chad on May 1 2015, 4:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 25, 6:06 AM
Unknown Object (File)
Fri, Jan 24, 3:42 AM
Unknown Object (File)
Fri, Jan 24, 3:42 AM
Unknown Object (File)
Fri, Jan 24, 3:42 AM
Unknown Object (File)
Fri, Jan 24, 3:42 AM
Unknown Object (File)
Wed, Jan 22, 4:59 PM
Unknown Object (File)
Wed, Jan 22, 3:07 PM
Unknown Object (File)
Tue, Jan 21, 8:09 PM
View All Files
Subscribers
aik099
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T1460: Add "Done" link to an inline comment
T7447: Bring inline comments forward across revision updates
Commits
Restricted Diffusion Commit
rP94299c0a6b19: Minor tweaks to inline comments
Summary

Ref T7447, Ref T1460. Moves "done" state to left, and no longer is a button (simpler CSS). Also feels a little nicer. Clean up some spacing issue with Ghosties.

Test Plan

Test new and old comments, as author and reviewer.

Screen Shot 2015-04-30 at 9.53.33 PM.png (518×1 px, 98 KB)

Screen Shot 2015-04-30 at 9.54.17 PM.png (590×1 px, 110 KB)

Screen Shot 2015-04-30 at 9.53.42 PM.png (438×1 px, 79 KB)

Diff Detail

Repository
rP Phabricator
Branch
ghost-15
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5644
Build 5663: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 30354.May 1 2015, 4:52 AM
chad retitled this revision from to Minor tweaks to inline comments.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added tasks: T7447: Bring inline comments forward across revision updates, T1460: Add "Done" link to an inline comment.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 1 2015, 4:52 AM
chad edited the test plan for this revision. (Show Details)May 1 2015, 4:54 AM
chad updated this revision to Diff 30355.May 1 2015, 5:22 AM
  • remove periods
aik099 added a subscriber: aik099.May 1 2015, 7:06 AM

What is ghost inline comments?

epriestley accepted this revision.May 1 2015, 12:29 PM
epriestley edited edge metadata.

See T7447 for a discussion of "ghosts" inlines.

This revision is now accepted and ready to land.May 1 2015, 12:29 PM
Closed by commit rP94299c0a6b19: Minor tweaks to inline comments (authored by chad, committed by chad). · Explain WhyMay 1 2015, 2:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
64 lines
src/
infrastructure/
diff/
view/
34 lines
webroot/
rsrc/
css/
application/
differential/
60 lines

Diff 30355

View Options

resources/celerity/map.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Loading...
View Options

webroot/rsrc/css/application/differential/phui-inline-comment.css

Loading...
Phabricator · Built by Phacility