Page MenuHomePhabricator
Differential D12640

Calendar events should support comments
ClosedPublic
Actions

Authored by lpriestley on May 1 2015, 12:25 AM.
Tags
None
Referenced Files
F15426541: D12640.id30351.diff
Sun, Mar 23, 9:30 AM
F15423778: D12640.id30352.diff
Sat, Mar 22, 6:11 PM
F15390318: D12640.id30352.diff
Sat, Mar 15, 6:07 AM
F15360765: D12640.id30352.diff
Tue, Mar 11, 10:05 AM
F15360764: D12640.id30351.diff
Tue, Mar 11, 10:05 AM
F15360763: D12640.id30350.diff
Tue, Mar 11, 10:05 AM
F15282899: D12640.diff
Tue, Mar 4, 3:25 AM
Unknown Object (File)
Feb 15 2025, 10:22 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7956: Support commenting on Calendar events
Commits
Restricted Diffusion Commit
rPbbba6241c2a1: Calendar events should support comments
Summary

Closes T7956, Calendar events should support comments.

Test Plan

Open event, add comment, save, comment should appear in timeline.

Diff Detail

Repository
rP Phabricator
Branch
calendareventcomments
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5642
Build 5661: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30350.May 1 2015, 12:25 AM
lpriestley retitled this revision from to Calendar events should support comments.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T7956: Support commenting on Calendar events.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 1 2015, 12:25 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
lpriestley updated this revision to Diff 30351.May 1 2015, 12:29 AM
lpriestley edited edge metadata.

Use getMonogram!

epriestley accepted this revision.May 1 2015, 12:31 AM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/calendar/application/PhabricatorCalendarApplication.php
59

indent for consistncyreys

src/applications/calendar/controller/PhabricatorCalendarEventCommentController.php
7–14

Consider modernizing to use handleRequest(AphrontRequest $request) instead.

11

Stray debugging code.

This revision is now accepted and ready to land.May 1 2015, 12:31 AM
lpriestley updated this revision to Diff 30352.May 1 2015, 12:37 AM
lpriestley marked 3 inline comments as done.
lpriestley edited edge metadata.

Considered modernizing it.

Closed by commit rPbbba6241c2a1: Calendar events should support comments (authored by lpriestley, committed by lpriestley). · Explain WhyMay 1 2015, 12:38 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30352

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/calendar/application/PhabricatorCalendarApplication.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventCommentController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Loading...
View Options

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php

Loading...
Phabricator · Built by Phacility