Paths

Table of Contentst

Differential D12640

Calendar events should support comments
ClosedPublic
Actions

Authored by lpriestley on May 1 2015, 12:25 AM.

Tags

None

Referenced Files

	F17736217: D12640.id30352.diff
	Sun, Jul 20, 4:38 PM

	F17735286: D12640.id30353.diff
	Sun, Jul 20, 1:35 PM

	F17734130: D12640.diff
	Sun, Jul 20, 10:02 AM

	Unknown Object (File)
	Wed, Jul 2, 5:49 AM

	Unknown Object (File)
	Wed, Jul 2, 5:47 AM

	Unknown Object (File)
	Tue, Jul 1, 10:08 PM

	Unknown Object (File)
	May 31 2025, 9:13 AM

	Unknown Object (File)
	May 31 2025, 5:42 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7956: Support commenting on Calendar events

Commits

Restricted Diffusion Commit
rPbbba6241c2a1: Calendar events should support comments

Summary

Closes T7956, Calendar events should support comments.

Test Plan

Open event, add comment, save, comment should appear in timeline.

Diff Detail

Repository

Branch

calendareventcomments

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5641
Build 5660: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30350.May 1 2015, 12:25 AM

lpriestley retitled this revision from to Calendar events should support comments.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T7956: Support commenting on Calendar events.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 1 2015, 12:25 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Use getMonogram!

epriestley accepted this revision.May 1 2015, 12:31 AM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/calendar/application/PhabricatorCalendarApplication.php
59	indent for consistncyreys
src/applications/calendar/controller/PhabricatorCalendarEventCommentController.php
6–13	Consider modernizing to use `handleRequest(AphrontRequest $request)` instead.
10	Stray debugging code.

This revision is now accepted and ready to land.May 1 2015, 12:31 AM

Considered modernizing it.

Closed by commit rPbbba6241c2a1: Calendar events should support comments (authored by lpriestley, committed by lpriestley). · Explain WhyMay 1 2015, 12:38 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

calendar/

application/

PhabricatorCalendarApplication.php

2 lines

controller/

PhabricatorCalendarEventCommentController.php

70 lines

PhabricatorCalendarEventViewController.php

15 lines

editor/

PhabricatorCalendarEventEditor.php

3 lines

Diff 30351

src/__phutil_library_map__.php

Loading...

src/applications/calendar/application/PhabricatorCalendarApplication.php

Loading...

src/applications/calendar/controller/PhabricatorCalendarEventCommentController.php

Loading...

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Loading...

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php

Loading...