Page MenuHomePhabricator
Differential D12638

Left nav should no longer offer to create Calendar event and create event page should no longer show left nav.
ClosedPublic
Actions

Authored by lpriestley on Apr 30 2015, 11:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 3:59 AM
Unknown Object (File)
Fri, Dec 6, 4:46 PM
Unknown Object (File)
Thu, Dec 5, 8:22 PM
Unknown Object (File)
Tue, Dec 3, 11:37 PM
Unknown Object (File)
Tue, Dec 3, 11:37 PM
Unknown Object (File)
Tue, Dec 3, 11:37 PM
Unknown Object (File)
Tue, Dec 3, 11:37 PM
Unknown Object (File)
Tue, Dec 3, 11:37 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7934: Remove "Create Event" from Calendar left nav
Commits
Restricted Diffusion Commit
rP5ca007044659: Left nav should no longer offer to create Calendar event and create event…
Summary

Closes T7934, Left nav should no longer offer to create Calendar event and create event page should no longer show left nav.

Test Plan

Open Calendar, left nav should be missing the Create Event option, create event, create view should no longer show left nav.

Diff Detail

Repository
rP Phabricator
Branch
calendareventleftnav
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5636
Build 5655: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30341.Apr 30 2015, 11:12 PM
lpriestley retitled this revision from to Left nav should no longer offer to create Calendar event and create event page should no longer show left nav..
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T7934: Remove "Create Event" from Calendar left nav.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 30 2015, 11:12 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 30 2015, 11:14 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
39–40

This can finally die, right?

60–61

And this one?

61–62

(And probably this one?)

This revision is now accepted and ready to land.Apr 30 2015, 11:14 PM
lpriestley updated this revision to Diff 30342.Apr 30 2015, 11:16 PM
lpriestley edited edge metadata.

Evil filters.

lpriestley updated this revision to Diff 30343.Apr 30 2015, 11:17 PM
lpriestley marked 2 inline comments as done.

More evils

lpriestley marked an inline comment as done.Apr 30 2015, 11:17 PM
Closed by commit rP5ca007044659: Left nav should no longer offer to create Calendar event and create event… (authored by lpriestley, committed by lpriestley). · Explain WhyApr 30 2015, 11:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
controller/
1 line
13 lines

Diff 30343

View Options

src/applications/calendar/controller/PhabricatorCalendarController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventEditController.php

Loading...
Phabricator · Built by Phacility