Calendar events should have edit/view policies
ClosedPublic
Actions

Authored by lpriestley on Apr 30 2015, 9:33 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7940: Support proper policies in Calendar

Commits

Restricted Diffusion Commit
rP11e8e60245ed: Calendar events should have edit/view policies

Summary

Closes T7940, Calendar events should have edit/view policies.

Test Plan

Create new event and save, event should be only visible and editable by creator. Editing policies should correctly set the permissions of editing/viewing the event.

Diff Detail

Repository

rP Phabricator

Branch

calendareventeditviewpolicies

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5625
Build 5644: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30327.Apr 30 2015, 9:33 PM

lpriestley retitled this revision from to Calendar events should have edit/view policies.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T7940: Support proper policies in Calendar.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 30 2015, 9:33 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Typo.

epriestley accepted this revision.Apr 30 2015, 9:39 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
37–38	These shouldn't be necessary, since `initializeNewCalendarEvent()` sets them for you automatically.
src/applications/calendar/storage/PhabricatorCalendarEvent.php
255–257	This could be omitted to slightly simplify things, since we'll just hit the `return false;` below anyway.