Page MenuHomePhabricator
Differential D12631

Calendar items in Upcoming Events query should link to events, not calendar
ClosedPublic
Actions

Authored by lpriestley on Apr 30 2015, 8:03 PM.
Tags
None
Referenced Files
F13211956: D12631.diff
Fri, May 17, 6:15 AM
F13195591: D12631.diff
Sun, May 12, 10:30 PM
F13178330: D12631.diff
Wed, May 8, 8:21 PM
Unknown Object (File)
Thu, May 2, 2:04 AM
Unknown Object (File)
Sat, Apr 27, 4:57 AM
Unknown Object (File)
Fri, Apr 26, 11:34 AM
Unknown Object (File)
Fri, Apr 26, 2:55 AM
Unknown Object (File)
Thu, Apr 25, 2:01 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7933: In list views, Calendar events link to months but should link to event detail pages
Commits
Restricted Diffusion Commit
rPf14e0bf2efb2: Calendar items in Upcoming Events query should link to events, not calendar
Summary

Closes T7933, Calendar items in Upcoming Events query should link to events, not calendar.

Test Plan

Open Upcoming Events query, click on an event, event detail view should open.

Diff Detail

Repository
rP Phabricator
Branch
calendareventupcomingquerylinks
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5623
Build 5642: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30325.Apr 30 2015, 8:03 PM
lpriestley retitled this revision from to Calendar items in Upcoming Events query should link to events, not calendar.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T7933: In list views, Calendar events link to months but should link to event detail pages.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 30 2015, 8:03 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 30 2015, 8:20 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 30 2015, 8:20 PM
Closed by commit rPf14e0bf2efb2: Calendar items in Upcoming Events query should link to events, not calendar (authored by lpriestley, committed by lpriestley). · Explain WhyApr 30 2015, 8:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
query/
22 lines

Diff 30325

View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...
Phabricator · Built by Phacility