Page MenuHomePhabricator
Differential D12625

Calendar event timeline feed should reflect invite changes better
ClosedPublic
Actions

Authored by lpriestley on Apr 30 2015, 5:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 7, 5:54 AM
Unknown Object (File)
Wed, Dec 4, 1:31 AM
Unknown Object (File)
Wed, Dec 4, 1:31 AM
Unknown Object (File)
Wed, Dec 4, 1:31 AM
Unknown Object (File)
Wed, Dec 4, 1:31 AM
Unknown Object (File)
Wed, Dec 4, 1:31 AM
Unknown Object (File)
Wed, Dec 4, 12:13 AM
Unknown Object (File)
Wed, Nov 27, 7:28 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7988: Create meaningful transaction messages
Commits
Restricted Diffusion Commit
rP69536ea3b988: Calendar event timeline feed should reflect invite changes better
Summary

Ref T7988, Calendar event timeline feed should better reflect invite changes.

Test Plan

Create or edit calendar event, invite or remove users, save, timeline feed should correctly reflect added/removed invitees.

Diff Detail

Repository
rP Phabricator
Branch
calendareventinvitetimeline
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5619
Build 5638: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30311.Apr 30 2015, 5:31 PM
lpriestley retitled this revision from to Calendar event timeline feed should reflect invite changes better.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T7988: Create meaningful transaction messages.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 30 2015, 5:31 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
lpriestley updated this revision to Diff 30313.Apr 30 2015, 5:41 PM
lpriestley edited edge metadata.

Newline cleanup

epriestley accepted this revision.Apr 30 2015, 5:48 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php
140–141

Consider omitting unreachable break; immediately after return;.

169

Extra break;

219

I think this is un-indented one level too many.

This revision is now accepted and ready to land.Apr 30 2015, 5:48 PM
lpriestley updated this revision to Diff 30318.Apr 30 2015, 6:18 PM
lpriestley marked 2 inline comments as done.
lpriestley edited edge metadata.

Removing unreachable breaks

lpriestley marked an inline comment as done.Apr 30 2015, 6:19 PM
Closed by commit rP69536ea3b988: Calendar event timeline feed should reflect invite changes better (authored by lpriestley, committed by lpriestley). · Explain WhyApr 30 2015, 6:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
storage/
104 lines

Diff 30318

View Options

src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php

Loading...
Phabricator · Built by Phacility