Closes T7935, Calendar events should now auto-invite the creator.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T7935: Give calendar events real invitee lists
- Commits
- Restricted Diffusion Commit
rPd4176606f952: Calendar events should now auto-invite the creator
Create event, save, event should now show creator as an invitee.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- calendareventinvitees
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 5595 Build 5614: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| src/applications/calendar/query/PhabricatorCalendarEventInviteeQuery.php | ||
|---|---|---|
| 56 | Minor, but prefer to check these strictly against null, e.g.: if ($this->ids !== null) { ... }This prevents a bug where callers do: ->withIDs(array()) ...by mistake and accidentally select every result. | |
| src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php | ||
| 303–305 | This might be worth breaking out separately at some point since I could imagine a user caring about the event getting rescheduled but not caring about the invitee list changing. Perfectly fine for now, though. | |
| src/applications/calendar/query/PhabricatorCalendarEventInviteeQuery.php | ||
|---|---|---|
| 62–88 | Oh, sorry, for all of these cases. | |