Paths

Table of Contentst

Quicksand - fix spooky back button issue
ClosedPublic
Actions

Authored by btrahan on Apr 29 2015, 12:10 AM.

Tags

None

Referenced Files

	F14824580: D12603.id30266.diff
	Tue, Jan 28, 5:56 PM

	F14822889: D12603.id30265.diff
	Tue, Jan 28, 10:03 AM

	Unknown Object (File)
	Fri, Jan 24, 3:26 AM

	Unknown Object (File)
	Fri, Jan 24, 3:26 AM

	Unknown Object (File)
	Fri, Jan 24, 3:26 AM

	Unknown Object (File)
	Fri, Jan 24, 3:26 AM

	Unknown Object (File)
	Thu, Jan 23, 3:51 PM

	Unknown Object (File)
	Tue, Jan 21, 10:22 AM

View All Files

Subscribers

epriestley

Korvin

Tokens

"Mountain of Wealth" token, awarded by epriestley.

Details

Reviewers

epriestley

Maniphest Tasks

T7911: Quicksand fails to navigate back to page 0 on Chrome, Firefox sporadically

Commits

Restricted Diffusion Commit
rP6575cc568dab: Quicksand - fix spooky back button issue

Summary

Fixes T7911.

Test Plan

load a page
click something else
go back to original page via clicking
browser refresh
click something else
browser back -- and it now works!

Diff Detail

Repository

rP Phabricator

Branch

T7911

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5581
Build 5600: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 30265.Apr 29 2015, 12:10 AM

btrahan added a task: T7911: Quicksand fails to navigate back to page 0 on Chrome, Firefox sporadically.

btrahan retitled this revision from to Quicksand - fix spooky back button issue.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 29 2015, 12:10 AM

Awesome! Nice breakthrough on the history.state + reload thing.

This revision is now accepted and ready to land.Apr 29 2015, 12:18 AM

epriestley awarded a token.Apr 29 2015, 12:19 AM

Thanks! :D

Closed by commit rP6575cc568dab: Quicksand - fix spooky back button issue (authored by btrahan, committed by btrahan). · Explain WhyApr 29 2015, 12:20 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

10 lines

webroot/

rsrc/

externals/

javelin/

lib/

Quicksand.js

5 lines

Diff 30265

View Options

resources/celerity/map.php