Paths

Table of Contentst

Differential D12591

Calendar events should now have a 'Name' field.
ClosedPublic
Actions

Authored by lpriestley on Apr 28 2015, 3:23 PM.

Tags

None

Referenced Files

	F14846665: D12591.diff
	Mon, Feb 3, 5:30 AM

	Unknown Object (File)
	Mon, Jan 27, 11:37 PM

	Unknown Object (File)
	Fri, Jan 24, 6:40 AM

	Unknown Object (File)
	Fri, Jan 24, 3:22 AM

	Unknown Object (File)
	Fri, Jan 24, 3:22 AM

	Unknown Object (File)
	Fri, Jan 24, 3:22 AM

	Unknown Object (File)
	Fri, Jan 24, 3:21 AM

	Unknown Object (File)
	Fri, Jan 17, 7:05 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7953: Give calendar events names

Commits

Restricted Diffusion Commit
rP43ab0e879fd9: Calendar events should now have a 'Name' field.

Summary

Closes T7953, Calendar events should now have a 'Name' field.

Test Plan

Create or edit event with no title, save event, should get error requiring name, event detail view timeline should reflect name changes.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 30230.Apr 28 2015, 3:23 PM

lpriestley retitled this revision from to Calendar events should now have a 'Name' field..

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T7953: Give calendar events names.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 28 2015, 3:23 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Minor inlines.

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php
105–107	Nuke.
src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php
78	Here or in a future diff, maybe render: %s created this event. ...if `$old === null`. You'd also have to remove TYPE_NAME from shouldHide() if you do this.

This revision is now accepted and ready to land.Apr 28 2015, 3:29 PM

Closed by commit rP43ab0e879fd9: Calendar events should now have a 'Name' field. (authored by lpriestley, committed by lpriestley). · Explain WhyApr 28 2015, 3:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20150428.calendar.1.name.sql

2 lines

src/

applications/

calendar/

controller/

PhabricatorCalendarEventEditController.php

109 lines

PhabricatorCalendarEventViewController.php

9 lines

editor/

PhabricatorCalendarEventEditor.php

37 lines

storage/

PhabricatorCalendarEvent.php

2 lines

PhabricatorCalendarEventTransaction.php

27 lines

Diff 30231

resources/sql/autopatches/20150428.calendar.1.name.sql

Loading...

src/applications/calendar/controller/PhabricatorCalendarEventEditController.php

Loading...

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Loading...

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php

Loading...

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...

src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php

Loading...