Page MenuHomePhabricator

Calendar events should now have a 'Name' field.
ClosedPublic

Authored by lpriestley on Apr 28 2015, 3:23 PM.
Tags
None
Referenced Files
F14035753: D12591.id30231.diff
Sun, Nov 10, 7:24 AM
F14021261: D12591.diff
Wed, Nov 6, 6:52 AM
F13974829: D12591.diff
Fri, Oct 18, 7:34 AM
Unknown Object (File)
Oct 4 2024, 4:39 AM
Unknown Object (File)
Sep 25 2024, 6:27 PM
Unknown Object (File)
Sep 20 2024, 3:49 AM
Unknown Object (File)
Sep 17 2024, 8:08 AM
Unknown Object (File)
Sep 12 2024, 7:05 AM
Subscribers

Details

Summary

Closes T7953, Calendar events should now have a 'Name' field.

Test Plan

Create or edit event with no title, save event, should get error requiring name, event detail view timeline should reflect name changes.

Diff Detail

Repository
rP Phabricator
Branch
calendareventnames
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5561
Build 5580: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley retitled this revision from to Calendar events should now have a 'Name' field..
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
epriestley edited edge metadata.

Minor inlines.

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php
105–107

Nuke.

src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php
78

Here or in a future diff, maybe render:

%s created this event.

...if $old === null. You'd also have to remove TYPE_NAME from shouldHide() if you do this.

This revision is now accepted and ready to land.Apr 28 2015, 3:29 PM
This revision was automatically updated to reflect the committed changes.