Closes T5464, Implement ApplicationTransactions in Calendar.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T5464: Use ApplicationTransactions in Calendar
- Commits
- Restricted Diffusion Commit
rP65329204a5f2: T5464, ApplicationTransactions for calendar events
Create a calendar event, update calendar event, detail view of event should show update history.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- calendarapplicationtransactions
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 5557 Build 5576: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Couple of minor inlines. Also:
- Looks like the .sql files didn't get added -- maybe a weird ~/.gitignore rule?
| src/applications/calendar/controller/PhabricatorCalendarEventEditController.php | ||
|---|---|---|
| 103 | For consistency, prefer getID() over getId(). | |
| src/applications/calendar/editor/PhabricatorCalendarEventEditor.php | ||
| 105–107 | Just remove this stuff for now. | |
| src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php | ||
| 12–15 | These probably shouldn't be four separate mail tags. Mail tags are used to offer preferences in Settings → Email Preferences so users can get email about more important events (like a task being opened or closed or commented on) but not be emailed about less important events (like priority changes or project adjustments). It doesn't seem very useful to set different preferences for the start and end times of an event. Even though "start time" is arguably a bit more important than "end time", I'd guess that almost all users probably always want to be notified in the same way about any scheduling change. I'd maybe provide two tags here instead:
| |
| 26 | Should be PhabricatorCalendarEventTransactionComment. | |
| src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php | ||
|---|---|---|
| 23 | Then add "Event" here too. | |
| 195–205 | This still uses the old tag constants. | |
| src/applications/calendar/storage/PhabricatorCalendarTransactionComment.php | ||
| 3 | Oh, this should be PhabricatorCalendarEventTransactionComment for consistency with the Transaction class and the table name (that is, add "Event"). | |
Comment Actions
Renaming PhabricatorCalendarTransactionComment.php to PhabricatorCalendarEventTransactionComment.php