Differential D12560

"Create Application" button in OAuth Server application should be greyed out if user does not have correct capabilities.
ClosedPublic
Actions

Authored by lpriestley on Apr 26 2015, 7:46 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7497: "Create Application" should be greyed out if not allowed by policy

Commits

Restricted Diffusion Commit
rP3f77ad9368c7: "Create Application" button in OAuth Server application should be greyed out…

Summary

Fixes T7497, "Create Application" button in Oauth Server application should be greyed out if user does not have correct capabilities and should open a "You Shall Not Pass" modal.

Test Plan

Login as non-admin, open OAuth Server application, "Create Application" button should be greyed out, and clicking it should open a modal dialog over the list view without navigating away from it.

Diff Detail

Repository

rP Phabricator

Branch

oauthservernewappbutton

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5516
Build 5535: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30149.Apr 26 2015, 7:46 PM

lpriestley retitled this revision from to "Create Application" button in OAuth Server application should be greyed out if user does not have correct capabilities..

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T7497: "Create Application" should be greyed out if not allowed by policy.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 26 2015, 7:46 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Apr 26 2015, 7:50 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 26 2015, 7:50 PM

Closed by commit rP3f77ad9368c7: "Create Application" button in OAuth Server application should be greyed out… (authored by lpriestley, committed by epriestley). · Explain WhyApr 26 2015, 7:51 PM

This revision was automatically updated to reflect the committed changes.