Differential D12559

Users with no build plan capabilities should see "New Build Plan" button as greyed out and a modal dialog explaining the policy.
ClosedPublic
Actions

Authored by lpriestley on Apr 26 2015, 7:39 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7499: "New Build Plan" should be greyed out if not allowed by policy

Commits

Restricted Diffusion Commit
rP80acaf68312c: Users with no build plan capabilities should see "New Build Plan" button as…

Summary

Fixes T7499, New Build Plan button should be greyed out in Harbormaster list view.

Test Plan

Login as non-admin user, navigate to Harbormaster, New Build Plan button should be greyed out and clicking it should result in a "You Shall Not Pass" modal dialog that does not navigate away from build list view.

Diff Detail

Repository

rP Phabricator

Branch

harbormasterdisallowednewbuild

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5515
Build 5534: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30147.Apr 26 2015, 7:39 PM

lpriestley retitled this revision from to Users with no build plan capabilities should see "New Build Plan" button as greyed out and a modal dialog explaining the policy..

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T7499: "New Build Plan" should be greyed out if not allowed by policy.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 26 2015, 7:39 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Apr 26 2015, 7:45 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 26 2015, 7:45 PM

Closed by commit rP80acaf68312c: Users with no build plan capabilities should see "New Build Plan" button as… (authored by lpriestley, committed by epriestley). · Explain WhyApr 26 2015, 7:45 PM

This revision was automatically updated to reflect the committed changes.