Simplify Mercurial ref resolution; expose "closed" at top-level
ClosedPublic
Actions

Authored by epriestley on Apr 25 2015, 9:18 PM.

Details

Reviewers

Maniphest Tasks

T6160: Don't show closed branches of mercurial repository
T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads)

Commits

Restricted Diffusion Commit
rP2c9b194d1673: Simplify Mercurial ref resolution; expose "closed" at top-level

Summary

Ref T7100. Ref T6160. Share branch code. Surface "closed".

Test Plan

Browsed a mercurial repository and saw consistent ref/cache state.

Diff Detail

Repository

rP Phabricator

Branch

repo5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5507
Build 5526: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30135.Apr 25 2015, 9:18 PM

epriestley retitled this revision from to Simplify Mercurial ref resolution; expose "closed" at top-level.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads), T6160: Don't show closed branches of mercurial repository.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 25 2015, 9:18 PM

btrahan accepted this revision.Apr 26 2015, 11:16 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 26 2015, 11:16 PM

Closed by commit rP2c9b194d1673: Simplify Mercurial ref resolution; expose "closed" at top-level (authored by epriestley, committed by epriestley). · Explain WhyApr 27 2015, 10:50 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

query/

DiffusionCachedResolveRefsQuery.php

3 lines

lowlevel/

DiffusionLowLevelResolveRefsQuery.php

46 lines

Diff 30135

View Options

src/applications/diffusion/query/DiffusionCachedResolveRefsQuery.php