Page MenuHomePhabricator
Differential D12551

Simplify Mercurial ref resolution; expose "closed" at top-level
ClosedPublic
Actions

Authored by epriestley on Apr 25 2015, 9:18 PM.
Tags
None
Referenced Files
F15415014: D12551.id30135.diff
Thu, Mar 20, 3:32 AM
F15410954: D12551.diff
Wed, Mar 19, 8:44 AM
F15410207: D12551.diff
Wed, Mar 19, 6:54 AM
F15397484: D12551.diff
Sun, Mar 16, 8:32 PM
F15380013: D12551.id30135.diff
Fri, Mar 14, 12:51 AM
F15379535: D12551.id.diff
Thu, Mar 13, 9:44 PM
Unknown Object (File)
Feb 9 2025, 6:24 PM
Unknown Object (File)
Feb 8 2025, 3:57 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T6160: Don't show closed branches of mercurial repository
T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads)
Commits
Restricted Diffusion Commit
rP2c9b194d1673: Simplify Mercurial ref resolution; expose "closed" at top-level
Summary

Ref T7100. Ref T6160. Share branch code. Surface "closed".

Test Plan

Browsed a mercurial repository and saw consistent ref/cache state.

Diff Detail

Repository
rP Phabricator
Branch
repo5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5507
Build 5526: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30135.Apr 25 2015, 9:18 PM
epriestley retitled this revision from to Simplify Mercurial ref resolution; expose "closed" at top-level.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads), T6160: Don't show closed branches of mercurial repository.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 25 2015, 9:18 PM
btrahan accepted this revision.Apr 26 2015, 11:16 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 26 2015, 11:16 PM
Closed by commit rP2c9b194d1673: Simplify Mercurial ref resolution; expose "closed" at top-level (authored by epriestley, committed by epriestley). · Explain WhyApr 27 2015, 10:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
query/
3 lines
lowlevel/
46 lines

Diff 30135

View Options

src/applications/diffusion/query/DiffusionCachedResolveRefsQuery.php

Loading...
View Options

src/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php

Loading...
Phabricator · Built by Phacility