Fix query types on maniphest fulltext search.
ClosedPublic
Actions

Authored by Pawka on Apr 24 2015, 5:58 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP7196d29c0c57: Fix query types on maniphest fulltext search.

Summary

Parameter type is not used anywhere. Instead param types is used.
Due this bug search was performed over whole index instead on tasks only.

Test Plan

Setup phabricator to run with Elasticsearch.
Open http://yourphab.com/conduit/method/maniphest.query/
Fill fullText field only.
Expect get results. Query should be performed on /phabricator/TASK/ only (not on whole /phabricator/ index).

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Pawka updated this revision to Diff 30116.Apr 24 2015, 5:58 PM

Pawka retitled this revision from to Fix query types on maniphest fulltext search..

Pawka updated this object.

Pawka edited the test plan for this revision. (Show Details)

Pawka added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 24 2015, 5:58 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Thanks!

This revision is now accepted and ready to land.Apr 24 2015, 6:16 PM

Closed by commit rP7196d29c0c57: Fix query types on maniphest fulltext search. (authored by Povilas Balzaravicius Pawka <povilas@uber.com>, committed by epriestley). · Explain WhyApr 24 2015, 6:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

query/

ManiphestTaskQuery.php

3 lines

Diff 30119

View Options

src/applications/maniphest/query/ManiphestTaskQuery.php

Fix query types on maniphest fulltext search.ClosedPublicActions