Page MenuHomePhabricator
Differential D12540

Update the search scope selector after Quicksand navigation
ClosedPublic
Actions

Authored by epriestley on Apr 24 2015, 5:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 2:25 PM
Unknown Object (File)
Mon, Dec 9, 3:42 AM
Unknown Object (File)
Nov 18 2024, 7:50 PM
Unknown Object (File)
Oct 28 2024, 3:40 PM
Unknown Object (File)
Oct 26 2024, 1:12 PM
Unknown Object (File)
Oct 13 2024, 10:49 AM
Unknown Object (File)
Oct 13 2024, 6:51 AM
Unknown Object (File)
Oct 5 2024, 8:53 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7900: Update search scope selector for Quicksand navigation
Commits
Restricted Diffusion Commit
rP0b309b6193d9: Update the search scope selector after Quicksand navigation
Summary

Fixes T7900.

  • Update the hidden form input so the current application is searched.
  • Update the menu icon.
  • Update the button icon, if "Search Current Application" is selected.
Test Plan
  • Navigated between applications with Quicksand.
    • Observed button icon update.
    • Observed menu icon update.
    • Observed results being scoped to the correct application.

Diff Detail

Repository
rP Phabricator
Branch
quick2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5491
Build 5510: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30113.Apr 24 2015, 5:42 PM
epriestley retitled this revision from to Update the search scope selector after Quicksand navigation.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7900: Update search scope selector for Quicksand navigation.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 24 2015, 5:42 PM
epriestley added inline comments.Apr 24 2015, 5:43 PM
webroot/rsrc/js/core/behavior-global-drag-and-drop.js
101–102

Pretty sure this wasn't doing anything intentionally.

btrahan accepted this revision.Apr 24 2015, 8:57 PM
btrahan edited edge metadata.
btrahan added inline comments.
webroot/rsrc/js/core/behavior-global-drag-and-drop.js
101–102

copy paste fo' sho'

This revision is now accepted and ready to land.Apr 24 2015, 8:57 PM
Closed by commit rP0b309b6193d9: Update the search scope selector after Quicksand navigation (authored by epriestley, committed by epriestley). · Explain WhyApr 24 2015, 9:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
36 lines
src/
view/
page/
15 lines
menu/
26 lines
webroot/
rsrc/
js/
core/
2 lines
53 lines

Diff 30113

View Options

resources/celerity/map.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
View Options

src/view/page/menu/PhabricatorMainMenuSearchView.php

Loading...
View Options

webroot/rsrc/js/core/behavior-global-drag-and-drop.js

Loading...
View Options

webroot/rsrc/js/core/behavior-search-typeahead.js

Loading...
Phabricator · Built by Phacility