Page MenuHomePhabricator
Differential D12504

Automatically support "Add Projects" in Herald for all relevant objects
ClosedPublic
Actions

Authored by epriestley on Apr 22 2015, 12:07 PM.
Tags
None
Referenced Files
F15498605: D12504.id30020.diff
Sun, Apr 13, 1:31 PM
F15490840: D12504.id30039.diff
Fri, Apr 11, 9:01 PM
F15484808: D12504.id.diff
Wed, Apr 9, 8:14 PM
F15483680: D12504.id30039.diff
Wed, Apr 9, 1:46 PM
F15481877: D12504.diff
Wed, Apr 9, 12:00 AM
F15481213: D12504.id30020.diff
Tue, Apr 8, 7:05 PM
F15477485: D12504.diff
Mon, Apr 7, 3:16 PM
F15422616: D12504.id30039.diff
Sat, Mar 22, 9:49 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7849: Allow herald rules to remove a project in HeraldManiphestTaskAdapter Actions
Commits
Restricted Diffusion Commit
rP959e9d9ac22c: Automatically support "Add Projects" in Herald for all relevant objects
Summary

Ref T7849. If the adapted object implements PhabricatorProjectInterface, support the ADD_PROJECTS action.

Test Plan
  • Wrote a Differential rule with "Add Projects".
  • Updated a revision.
  • Got projects added.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 30020.Apr 22 2015, 12:07 PM
epriestley retitled this revision from to Automatically support "Add Projects" in Herald for all relevant objects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7849: Allow herald rules to remove a project in HeraldManiphestTaskAdapter Actions.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 22 2015, 12:07 PM
btrahan accepted this revision.Apr 22 2015, 5:32 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 22 2015, 5:32 PM
Closed by commit rP959e9d9ac22c: Automatically support "Add Projects" in Herald for all relevant objects (authored by epriestley, committed by epriestley). · Explain WhyApr 22 2015, 9:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30039

View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldCommitAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldManiphestTaskAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldPholioMockAdapter.php

Loading...
View Options

src/applications/phriction/herald/PhrictionDocumentHeraldAdapter.php

Loading...
Phabricator · Built by Phacility