Page MenuHomePhabricator
Differential D12503

Make adding projects a standard Herald effect
ClosedPublic
Actions

Authored by epriestley on Apr 22 2015, 11:50 AM.
Tags
None
Referenced Files
F14042209: D12503.diff
Tue, Nov 12, 1:23 AM
F14025418: D12503.diff
Thu, Nov 7, 5:42 PM
F14006245: D12503.diff
Mon, Oct 28, 4:02 AM
F13967933: D12503.diff
Wed, Oct 16, 5:13 PM
F13956539: D12503.id30038.diff
Mon, Oct 14, 6:09 AM
Unknown Object (File)
Oct 8 2024, 3:51 AM
Unknown Object (File)
Oct 2 2024, 12:55 AM
Unknown Object (File)
Sep 23 2024, 10:55 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7849: Allow herald rules to remove a project in HeraldManiphestTaskAdapter Actions
Commits
Restricted Diffusion Commit
rP501630d931cf: Make adding projects a standard Herald effect
Summary

Ref T7849. Lift project actions into the base class. Some day they'll be fully modular.

Test Plan
  • Wrote an "add projects" Herald rule.
  • Edited Maniphest tasks.
  • Got projects added.

Diff Detail

Repository
rP Phabricator
Branch
paction2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5434
Build 5452: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30018.Apr 22 2015, 11:50 AM
epriestley retitled this revision from to Make adding projects a standard Herald effect.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7849: Allow herald rules to remove a project in HeraldManiphestTaskAdapter Actions.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 22 2015, 11:50 AM
btrahan accepted this revision.Apr 22 2015, 5:30 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 22 2015, 5:30 PM
Closed by commit rP501630d931cf: Make adding projects a standard Herald effect (authored by epriestley, committed by epriestley). · Explain WhyApr 22 2015, 9:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
herald/
adapter/
56 lines
18 lines
maniphest/
editor/
12 lines

Diff 30018

View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldManiphestTaskAdapter.php

Loading...
View Options

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Loading...
Phabricator · Built by Phacility