Page MenuHomePhabricator
Differential D12496

Simplify timeline rendering on Differential revisions
ClosedPublic
Actions

Authored by epriestley on Apr 21 2015, 8:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 6, 3:38 AM
Unknown Object (File)
Sun, Dec 1, 3:45 AM
Unknown Object (File)
Thu, Nov 28, 7:18 PM
Unknown Object (File)
Wed, Nov 27, 4:14 PM
Unknown Object (File)
Wed, Nov 27, 12:21 AM
Unknown Object (File)
Sun, Nov 24, 1:55 AM
Unknown Object (File)
Nov 18 2024, 4:47 PM
Unknown Object (File)
Nov 9 2024, 8:56 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7447: Bring inline comments forward across revision updates
Commits
Restricted Diffusion Commit
rPd8bd3efa2c69: Simplify timeline rendering on Differential revisions
Summary

Ref T7447. Remove the loadInlineComments() by-ref side-effect mess and make this load more direct.

Test Plan
  • Viewed a revision.
  • Clicked "Show Older".

Diff Detail

Repository
rP Phabricator
Branch
ghost2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5424
Build 5442: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30003.Apr 21 2015, 8:14 PM
epriestley retitled this revision from to Simplify timeline rendering on Differential revisions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7447: Bring inline comments forward across revision updates.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 21 2015, 8:14 PM
btrahan accepted this revision.Apr 21 2015, 10:13 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 21 2015, 10:13 PM
Closed by commit rPd8bd3efa2c69: Simplify timeline rendering on Differential revisions (authored by epriestley, committed by epriestley). · Explain WhyApr 21 2015, 10:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
storage/
65 lines

Diff 30003

View Options

src/applications/differential/storage/DifferentialRevision.php

Loading...
Phabricator · Built by Phacility