Page MenuHomePhabricator
Differential D12496

Simplify timeline rendering on Differential revisions
ClosedPublic
Actions

Authored by epriestley on Apr 21 2015, 8:14 PM.
Tags
None
Referenced Files
F18904382: D12496.id.diff
Sat, Nov 8, 8:47 AM
F18876718: D12496.diff
Thu, Nov 6, 2:55 AM
F18825928: D12496.diff
Fri, Oct 24, 1:10 AM
F18790466: D12496.id30007.diff
Oct 15 2025, 2:46 PM
F18756058: D12496.id.diff
Oct 5 2025, 9:00 AM
F18751599: D12496.id30003.diff
Oct 4 2025, 11:48 AM
F18750471: D12496.diff
Oct 4 2025, 7:55 AM
F18635013: D12496.id30007.diff
Sep 17 2025, 12:01 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7447: Bring inline comments forward across revision updates
Commits
Restricted Diffusion Commit
rPd8bd3efa2c69: Simplify timeline rendering on Differential revisions
Summary

Ref T7447. Remove the loadInlineComments() by-ref side-effect mess and make this load more direct.

Test Plan
  • Viewed a revision.
  • Clicked "Show Older".

Diff Detail

Repository
rP Phabricator
Branch
ghost2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5424
Build 5442: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30003.Apr 21 2015, 8:14 PM
epriestley retitled this revision from to Simplify timeline rendering on Differential revisions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7447: Bring inline comments forward across revision updates.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 21 2015, 8:14 PM
btrahan accepted this revision.Apr 21 2015, 10:13 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 21 2015, 10:13 PM
Closed by commit rPd8bd3efa2c69: Simplify timeline rendering on Differential revisions (authored by epriestley, committed by epriestley). · Explain WhyApr 21 2015, 10:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
storage/
65 lines

Diff 30003

View Options

src/applications/differential/storage/DifferentialRevision.php

Loading...
Phabricator · Built by Phacility