Differential D12487

Quicksand - update title while navigating about
ClosedPublic
Actions

Authored by btrahan on Apr 21 2015, 12:22 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T7744: Page Title not always updated when navigating in Quicksand

Commits

Restricted Diffusion Commit
rP2fab72d43bf6: Quicksand - update title while navigating about

Summary

Fixes T7744. Also fixes a bug where we were copying the response object erroneously; that's not necessary to move around since we cleanly initialize it for each load

Test Plan

from user profile, clicked feed tab and saw new title. clicked calendar tab and saw new title. clicked back and saw feed title and page render.

Diff Detail

Repository

rP Phabricator

Branch

T7744

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5414
Build 5432: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 29980.Apr 21 2015, 12:22 AM

btrahan added a task: T7744: Page Title not always updated when navigating in Quicksand.

btrahan retitled this revision from to Quicksand - update title while navigating about.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 21 2015, 12:22 AM

btrahan added inline comments.Apr 21 2015, 5:39 PM

webroot/rsrc/js/application/conpherence/behavior-durable-column.js
344–350	I put this in the durable column behavior because JX.Title is not in Javelin (its in Phabricator). Otherwise, I would have put it in Quickling directly in the draw method.