Fix typeahead browse dialog paging
ClosedPublic
Actions

Authored by epriestley on Apr 18 2015, 6:08 PM.

Tags

None

Referenced Files

	F15505500: D12461.id.diff
	Tue, Apr 15, 3:31 AM

	F15469993: D12461.id29909.diff
	Fri, Apr 4, 6:51 PM

	F15435802: D12461.diff
	Tue, Mar 25, 10:18 AM

	F15393122: D12461.id29908.diff
	Mar 15 2025, 7:47 PM

	F15392877: D12461.id.diff
	Mar 15 2025, 6:09 PM

	F15387519: D12461.id29909.diff
	Mar 15 2025, 2:32 AM

	Unknown Object (File)
	Feb 12 2025, 6:45 AM

	Unknown Object (File)
	Feb 12 2025, 6:45 AM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan
chad

Commits

Restricted Diffusion Commit
rPe5b97cd17c36: Fix typeahead browse dialog paging

Summary

This accidentally got disabled; we need to pull one more result that we'll use to tell if there's a next page.

Test Plan

Saw "more results" again.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5374
Build 5392: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29908.Apr 18 2015, 6:08 PM

epriestley retitled this revision from to Fix typeahead browse dialog paging.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 18 2015, 6:08 PM

chad accepted this revision.Apr 18 2015, 6:09 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 18 2015, 6:09 PM

Closed by commit rPe5b97cd17c36: Fix typeahead browse dialog paging (authored by epriestley, committed by epriestley). · Explain WhyApr 18 2015, 6:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

typeahead/

controller/

PhabricatorTypeaheadModularDatasourceController.php

3 lines

Diff 29908

View Options

src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php

Fix typeahead browse dialog pagingClosedPublicActions