Page MenuHomePhabricator

Cheat my way through the rest of the typeahead datasources
ClosedPublic

Authored by epriestley on Apr 16 2015, 6:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 3:37 AM
Unknown Object (File)
Wed, Dec 4, 1:59 AM
Unknown Object (File)
Thu, Nov 28, 1:10 AM
Unknown Object (File)
Oct 23 2024, 5:37 AM
Unknown Object (File)
Oct 14 2024, 8:07 PM
Unknown Object (File)
Oct 11 2024, 3:03 PM
Unknown Object (File)
Oct 1 2024, 11:01 PM
Unknown Object (File)
Oct 1 2024, 10:15 AM
Subscribers

Details

Summary

Ref T5750. These are a pain to modernize and most don't matter, so cheat:

  • Mark a bunch nonbrowsable, including some that probably should be browsable but which I don't want to deal with for now.
  • For static datasources, add an easy server-side filter (this isn't really cheating, and is appropriate for the status/priority/application datasources).
  • Make composite sources browsable if their components are browsable.
Test Plan
  • Tried to browse an unbrowsable source, got a 404.
  • Browsed a composite source.
  • Browsed static sources (priority/status/applications).
  • Browsed normal sources (people/projects).

Event Timeline

epriestley retitled this revision from to Cheat my way through the rest of the typeahead datasources.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 17 2015, 5:29 PM
This revision was automatically updated to reflect the committed changes.