Page MenuHomePhabricator
Differential D12425

Make tokenizer browse view paging work correctly
ClosedPublic
Actions

Authored by epriestley on Apr 15 2015, 5:04 PM.
Tags
None
Referenced Files
F14040052: D12425.id29874.diff
Mon, Nov 11, 7:13 AM
F14029087: D12425.id.diff
Fri, Nov 8, 7:21 PM
F14028921: D12425.id29834.diff
Fri, Nov 8, 5:54 PM
F14028909: D12425.id29874.diff
Fri, Nov 8, 5:47 PM
F14028876: D12425.diff
Fri, Nov 8, 5:13 PM
F14028611: D12425.diff
Fri, Nov 8, 2:34 PM
F14017312: D12425.id29874.diff
Mon, Nov 4, 4:19 PM
F13994372: D12425.diff
Wed, Oct 23, 5:42 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T5750: Implement typeahead browse mode
Commits
Restricted Diffusion Commit
rP06d79703d6e3: Make tokenizer browse view paging work correctly
Summary

Ref T5750. Adds a working "more results". Hard limits at 1000 results to mitigate the amount of trouble offset paging can get us into.

Test Plan

Artificially set hard limit down; clicked through results.

Screen_Shot_2015-04-15_at_9.58.52_AM.png (966×1 px, 154 KB)

Screen_Shot_2015-04-15_at_9.59.33_AM.png (966×1 px, 167 KB)

Diff Detail

Repository
rP Phabricator
Branch
type3
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/application/typeahead/behavior-typeahead-browse.js:1JAVELIN5`javelinsymbols` Not In Path
Unit
No Test Coverage
Build Status
Buildable 5326
Build 5344: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29834.Apr 15 2015, 5:04 PM
epriestley retitled this revision from to Make tokenizer browse view paging work correctly.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5750: Implement typeahead browse mode.
Herald added a reviewer: chad. · View Herald TranscriptApr 15 2015, 5:04 PM
Herald added a subscriber: epriestley. · View Herald Transcript
btrahan accepted this revision.Apr 15 2015, 5:16 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 15 2015, 5:16 PM
Closed by commit rP06d79703d6e3: Make tokenizer browse view paging work correctly (authored by epriestley, committed by epriestley). · Explain WhyApr 17 2015, 6:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
applications/
typeahead/
controller/
65 lines
webroot/
rsrc/
css/
aphront/
34 lines
js/
application/
typeahead/
31 lines

Diff 29834

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php

Loading...
View Options

webroot/rsrc/css/aphront/typeahead-browse.css

Loading...
View Options

webroot/rsrc/js/application/typeahead/behavior-typeahead-browse.js

Loading...
Phabricator · Built by Phacility