Fix a fatal for 404s in Phriction
ClosedPublic
Actions

Authored by epriestley on Apr 13 2015, 9:37 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T7817: Fatal for invalid Phriction document

Commits

Restricted Diffusion Commit
rP281bdf87cf63: Fix a fatal for 404s in Phriction

Summary

Fixes T7817. Not all documents have $content, so don't try to set a timestamp if there's no content.

An example is /w/asdlkfnalskdnfaslk/, i.e. the 404 document.

Test Plan

Hit /w/junk/ and got a nice 404 instead of a fatal.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29788.Apr 13 2015, 9:37 PM

epriestley retitled this revision from to Fix a fatal for 404s in Phriction.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, chad.

epriestley added a task: T7817: Fatal for invalid Phriction document.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 13 2015, 9:37 PM

btrahan accepted this revision.Apr 13 2015, 9:40 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 13 2015, 9:40 PM

Closed by commit rP281bdf87cf63: Fix a fatal for 404s in Phriction (authored by epriestley, committed by epriestley). · Explain WhyApr 13 2015, 9:44 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T8233: Unhandled Exception ("RuntimeException")-Undefined variable: content.May 18 2015, 4:37 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

controller/

PhrictionDocumentController.php

8 lines

Diff 29791

View Options

src/applications/phriction/controller/PhrictionDocumentController.php

Fix a fatal for 404s in PhrictionClosedPublicActions