Page MenuHomePhabricator
Differential D12380

Give Conduit params/return/errors protected visibility
ClosedPublic
Actions

Authored by epriestley on Apr 12 2015, 11:02 PM.
Tags
None
Referenced Files
F13235492: D12380.diff
Tue, May 21, 5:33 AM
F13233793: D12380.diff
Tue, May 21, 2:35 AM
F13219110: D12380.id29771.diff
Sat, May 18, 3:25 PM
F13217144: D12380.diff
Sat, May 18, 3:43 AM
F13214922: D12380.largetrue.diff
Fri, May 17, 1:49 PM
F13212028: D12380.diff
Fri, May 17, 6:19 AM
F13206035: D12380.id29723.diff
Wed, May 15, 4:49 AM
F13197051: D12380.diff
Sun, May 12, 11:47 PM
View All Files
Subscribers
epriestley
hach-que

Details

Reviewers
btrahan
Maniphest Tasks
T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges
T7803: Implement a composite query which unifies cursor paging across subqueries
Commits
Restricted Diffusion Commit
rP156b156e77b6: Give Conduit params/return/errors protected visibility
Summary

Ref T7803. Ref T5873. I want to drive Conduit through more shared infrastructure, but can't currently add parameters automatically.

Put a getX() around the defineX() methods so the parent can provide default behaviors.

Also like 60% of methods don't define any special error types; don't require them to implement this method. I want to move away from this in general.

Test Plan
  • Ran arc unit --everything.
  • Called conduit.query.
  • Browsed Conduit UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29723.Apr 12 2015, 11:02 PM
epriestley retitled this revision from to Give Conduit params/return/errors protected visibility.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T7803: Implement a composite query which unifies cursor paging across subqueries, T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.
Herald added subscribers: epriestley, hach-que. · View Herald TranscriptApr 12 2015, 11:02 PM
btrahan accepted this revision.Apr 13 2015, 6:12 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 6:12 PM
Closed by commit rP156b156e77b6: Give Conduit params/return/errors protected visibility (authored by epriestley, committed by epriestley). · Explain WhyApr 13 2015, 7:01 PM
This revision was automatically updated to reflect the committed changes.

Large Diff

This large diff affects 140 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
src/
applications/
almanac/
conduit/
8 lines
8 lines
arcanist/
conduit/
6 lines
audit/
conduit/
9 lines
auth/
conduit/
8 lines
chatlog/
conduit/
8 lines
8 lines
conduit/
call/
6 lines
controller/
6 lines
method/
25 lines
6 lines
8 lines
6 lines
8 lines
12 lines
conpherence/
conduit/
6 lines
8 lines
6 lines
6 lines
differential/
conduit/
6 lines
6 lines
9 lines
6 lines
9 lines
6 lines
9 lines
6 lines
8 lines
6 lines
6 lines
6 lines
6 lines
9 lines
6 lines
8 lines
6 lines
8 lines
6 lines
6 lines
6 lines
diffusion/
conduit/
2 lines
2 lines
2 lines
6 lines
2 lines
2 lines
2 lines
9 lines
8 lines
8 lines
9 lines
2 lines
2 lines
8 lines
2 lines
8 lines
4 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
8 lines
query/
2 lines
feed/
conduit/
9 lines
6 lines
files/
conduit/
8 lines
6 lines
6 lines
8 lines
8 lines
9 lines
9 lines
flag/
conduit/
6 lines
9 lines
9 lines
harbormaster/
conduit/
8 lines
8 lines
8 lines
macro/
conduit/
6 lines
9 lines
maniphest/
conduit/
2 lines
6 lines
9 lines
6 lines
8 lines
8 lines
6 lines
nuance/
conduit/
6 lines
owners/
conduit/
6 lines
passphrase/
conduit/
8 lines
paste/
conduit/
6 lines
6 lines
8 lines
people/
conduit/
6 lines
6 lines
6 lines
9 lines
6 lines
6 lines
8 lines
phame/
conduit/
6 lines
8 lines
9 lines
phid/
conduit/
6 lines
8 lines
8 lines
phragment/
conduit/
6 lines
6 lines
phrequent/
conduit/
9 lines
9 lines
9 lines
phriction/
conduit/
13 lines
9 lines
6 lines
6 lines
project/
conduit/
8 lines
8 lines
releeph/
conduit/
9 lines
6 lines
8 lines
8 lines
8 lines
6 lines
work/
8 lines
8 lines
8 lines
8 lines
8 lines
6 lines
8 lines
8 lines
remarkup/
conduit/
6 lines
repository/
conduit/
6 lines
9 lines
slowvote/
conduit/
6 lines
tokens/
conduit/
8 lines
8 lines
8 lines

Diff 29771

View Options

src/applications/almanac/conduit/AlmanacQueryDevicesConduitAPIMethod.php

View Options

src/applications/almanac/conduit/AlmanacQueryServicesConduitAPIMethod.php

View Options

src/applications/arcanist/conduit/ArcanistProjectInfoConduitAPIMethod.php

View Options

src/applications/audit/conduit/AuditQueryConduitAPIMethod.php

View Options

src/applications/auth/conduit/PhabricatorAuthQueryPublicKeysConduitAPIMethod.php

View Options

src/applications/chatlog/conduit/ChatLogQueryConduitAPIMethod.php

View Options

src/applications/chatlog/conduit/ChatLogRecordConduitAPIMethod.php

View Options

src/applications/conduit/call/ConduitCall.php

View Options

src/applications/conduit/controller/PhabricatorConduitConsoleController.php

View Options

src/applications/conduit/method/ConduitAPIMethod.php

View Options

src/applications/conduit/method/ConduitConnectConduitAPIMethod.php

View Options

src/applications/conduit/method/ConduitGetCapabilitiesConduitAPIMethod.php

View Options

src/applications/conduit/method/ConduitGetCertificateConduitAPIMethod.php

View Options

src/applications/conduit/method/ConduitPingConduitAPIMethod.php

View Options

src/applications/conduit/method/ConduitQueryConduitAPIMethod.php

View Options

src/applications/conpherence/conduit/ConpherenceCreateThreadConduitAPIMethod.php

View Options

src/applications/conpherence/conduit/ConpherenceQueryThreadConduitAPIMethod.php

View Options

src/applications/conpherence/conduit/ConpherenceQueryTransactionConduitAPIMethod.php

View Options

src/applications/conpherence/conduit/ConpherenceUpdateThreadConduitAPIMethod.php

View Options

src/applications/differential/conduit/DifferentialCloseConduitAPIMethod.php

View Options

src/applications/differential/conduit/DifferentialCreateCommentConduitAPIMethod.php

View Options

src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php

View Options

src/applications/differential/conduit/DifferentialCreateInlineConduitAPIMethod.php

View Options

src/applications/differential/conduit/DifferentialCreateRawDiffConduitAPIMethod.php

View Options

src/applications/differential/conduit/DifferentialCreateRevisionConduitAPIMethod.php

View Options

src/applications/differential/conduit/DifferentialFindConduitAPIMethod.php

View Options

src/applications/differential/conduit/DifferentialFinishPostponedLintersConduitAPIMethod.php

View Options

src/applications/differential/conduit/DifferentialGetAllDiffsConduitAPIMethod.php

View Options

src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php

View Options

src/applications/differential/conduit/DifferentialGetCommitPathsConduitAPIMethod.php

View Options

src/applications/differential/conduit/DifferentialGetDiffConduitAPIMethod.php

View Options

src/applications/differential/conduit/DifferentialGetRawDiffConduitAPIMethod.php

View Options

src/applications/differential/conduit/DifferentialGetRevisionCommentsConduitAPIMethod.php

View Options

src/applications/differential/conduit/DifferentialGetRevisionConduitAPIMethod.php

View Options

src/applications/differential/conduit/DifferentialParseCommitMessageConduitAPIMethod.php

View Options

src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php

View Options

src/applications/differential/conduit/DifferentialQueryDiffsConduitAPIMethod.php

View Options

src/applications/differential/conduit/DifferentialSetDiffPropertyConduitAPIMethod.php

View Options

src/applications/differential/conduit/DifferentialUpdateRevisionConduitAPIMethod.php

View Options

src/applications/differential/conduit/DifferentialUpdateUnitResultsConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionBranchQueryConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionCommitParentsQueryConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionCreateCommentConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionDiffQueryConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionExistsQueryConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionFileContentQueryConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionFindSymbolsConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionGetCommitsConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionGetLintMessagesConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionGetRecentCommitsByPathConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionLastModifiedQueryConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionLookSoonConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionMergedCommitsQueryConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionQueryCommitsConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionQueryConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionQueryPathsConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionRawDiffQueryConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionRefsQueryConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionResolveRefsConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionSearchQueryConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionTagsQueryConduitAPIMethod.php

View Options

src/applications/diffusion/conduit/DiffusionUpdateCoverageConduitAPIMethod.php

View Options

src/applications/diffusion/query/DiffusionQuery.php

View Options

src/applications/feed/conduit/FeedPublishConduitAPIMethod.php

View Options

src/applications/feed/conduit/FeedQueryConduitAPIMethod.php

View Options

src/applications/files/conduit/FileAllocateConduitAPIMethod.php

View Options

src/applications/files/conduit/FileDownloadConduitAPIMethod.php

View Options

src/applications/files/conduit/FileInfoConduitAPIMethod.php

View Options

src/applications/files/conduit/FileQueryChunksConduitAPIMethod.php

View Options

src/applications/files/conduit/FileUploadChunkConduitAPIMethod.php

View Options

src/applications/files/conduit/FileUploadConduitAPIMethod.php

View Options

src/applications/files/conduit/FileUploadHashConduitAPIMethod.php

View Options

src/applications/flag/conduit/FlagDeleteConduitAPIMethod.php

View Options

src/applications/flag/conduit/FlagEditConduitAPIMethod.php

View Options

src/applications/flag/conduit/FlagQueryConduitAPIMethod.php

View Options

src/applications/harbormaster/conduit/HarbormasterQueryBuildablesConduitAPIMethod.php

View Options

src/applications/harbormaster/conduit/HarbormasterQueryBuildsConduitAPIMethod.php

View Options

src/applications/harbormaster/conduit/HarbormasterSendMessageConduitAPIMethod.php

View Options

src/applications/macro/conduit/MacroCreateMemeConduitAPIMethod.php

View Options

src/applications/macro/conduit/MacroQueryConduitAPIMethod.php

View Options

src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php

View Options

src/applications/maniphest/conduit/ManiphestCreateTaskConduitAPIMethod.php

View Options

src/applications/maniphest/conduit/ManiphestGetTaskTransactionsConduitAPIMethod.php

View Options

src/applications/maniphest/conduit/ManiphestInfoConduitAPIMethod.php

View Options

src/applications/maniphest/conduit/ManiphestQueryConduitAPIMethod.php

View Options

src/applications/maniphest/conduit/ManiphestQueryStatusesConduitAPIMethod.php

View Options

src/applications/maniphest/conduit/ManiphestUpdateConduitAPIMethod.php

View Options

src/applications/nuance/conduit/NuanceCreateItemConduitAPIMethod.php

View Options

src/applications/owners/conduit/OwnersQueryConduitAPIMethod.php

View Options

src/applications/passphrase/conduit/PassphraseQueryConduitAPIMethod.php

View Options

src/applications/paste/conduit/PasteCreateConduitAPIMethod.php

View Options

src/applications/paste/conduit/PasteInfoConduitAPIMethod.php

View Options

src/applications/paste/conduit/PasteQueryConduitAPIMethod.php

View Options

src/applications/people/conduit/UserAddStatusConduitAPIMethod.php

View Options

src/applications/people/conduit/UserDisableConduitAPIMethod.php

View Options

src/applications/people/conduit/UserEnableConduitAPIMethod.php

View Options

src/applications/people/conduit/UserFindConduitAPIMethod.php

View Options

src/applications/people/conduit/UserQueryConduitAPIMethod.php

View Options

src/applications/people/conduit/UserRemoveStatusConduitAPIMethod.php

View Options

src/applications/people/conduit/UserWhoAmIConduitAPIMethod.php

View Options

src/applications/phame/conduit/PhameCreatePostConduitAPIMethod.php

View Options

src/applications/phame/conduit/PhameQueryConduitAPIMethod.php

View Options

src/applications/phame/conduit/PhameQueryPostsConduitAPIMethod.php

View Options

src/applications/phid/conduit/PHIDInfoConduitAPIMethod.php

View Options

src/applications/phid/conduit/PHIDLookupConduitAPIMethod.php

View Options

src/applications/phid/conduit/PHIDQueryConduitAPIMethod.php

View Options

src/applications/phragment/conduit/PhragmentGetPatchConduitAPIMethod.php

View Options

src/applications/phragment/conduit/PhragmentQueryFragmentsConduitAPIMethod.php

View Options

src/applications/phrequent/conduit/PhrequentPopConduitAPIMethod.php

View Options

src/applications/phrequent/conduit/PhrequentPushConduitAPIMethod.php

View Options

src/applications/phrequent/conduit/PhrequentTrackingConduitAPIMethod.php

View Options

src/applications/phriction/conduit/PhrictionCreateConduitAPIMethod.php

View Options

src/applications/phriction/conduit/PhrictionEditConduitAPIMethod.php

View Options

src/applications/phriction/conduit/PhrictionHistoryConduitAPIMethod.php

View Options

src/applications/phriction/conduit/PhrictionInfoConduitAPIMethod.php

View Options

src/applications/project/conduit/ProjectCreateConduitAPIMethod.php

View Options

src/applications/project/conduit/ProjectQueryConduitAPIMethod.php

View Options

src/applications/releeph/conduit/ReleephGetBranchesConduitAPIMethod.php

View Options

src/applications/releeph/conduit/ReleephProjectInfoConduitAPIMethod.php

View Options

src/applications/releeph/conduit/ReleephQueryBranchesConduitAPIMethod.php

View Options

src/applications/releeph/conduit/ReleephQueryProductsConduitAPIMethod.php

View Options

src/applications/releeph/conduit/ReleephQueryRequestsConduitAPIMethod.php

View Options

src/applications/releeph/conduit/ReleephRequestConduitAPIMethod.php

View Options

src/applications/releeph/conduit/work/ReleephWorkCanPushConduitAPIMethod.php

View Options

src/applications/releeph/conduit/work/ReleephWorkGetAuthorInfoConduitAPIMethod.php

View Options

src/applications/releeph/conduit/work/ReleephWorkGetBranchCommitMessageConduitAPIMethod.php

View Options

src/applications/releeph/conduit/work/ReleephWorkGetBranchConduitAPIMethod.php

View Options

src/applications/releeph/conduit/work/ReleephWorkGetCommitMessageConduitAPIMethod.php

View Options

src/applications/releeph/conduit/work/ReleephWorkNextRequestConduitAPIMethod.php

View Options

src/applications/releeph/conduit/work/ReleephWorkRecordConduitAPIMethod.php

View Options

src/applications/releeph/conduit/work/ReleephWorkRecordPickStatusConduitAPIMethod.php

View Options

src/applications/remarkup/conduit/RemarkupProcessConduitAPIMethod.php

View Options

src/applications/repository/conduit/RepositoryCreateConduitAPIMethod.php

View Options

src/applications/repository/conduit/RepositoryQueryConduitAPIMethod.php

View Options

src/applications/slowvote/conduit/SlowvoteInfoConduitAPIMethod.php

View Options

src/applications/tokens/conduit/TokenGiveConduitAPIMethod.php

View Options

src/applications/tokens/conduit/TokenGivenConduitAPIMethod.php

View Options

src/applications/tokens/conduit/TokenQueryConduitAPIMethod.php

Phabricator · Built by Phacility