Page MenuHomePhabricator
Differential D12384

Add setEpoch for PHUIHeaderView, use in all Documents
ClosedPublic
Actions

Authored by chad on Apr 13 2015, 12:09 AM.
Tags
None
Referenced Files
F15443697: D12384.id29728.diff
Thu, Mar 27, 5:43 AM
F15439478: D12384.id29727.diff
Wed, Mar 26, 7:44 AM
F15398503: D12384.id.diff
Mar 17 2025, 12:26 AM
F15340595: D12384.diff
Mar 9 2025, 3:45 PM
F15284758: D12384.diff
Mar 4 2025, 10:28 AM
Unknown Object (File)
Feb 17 2025, 2:29 PM
Unknown Object (File)
Feb 12 2025, 3:18 AM
Unknown Object (File)
Feb 8 2025, 3:39 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP4ab9ebd9013a: Add setEpoch for PHUIHeaderView, use in all Documents
Summary

Sets a consistent last update time in the header of PHUIDocuments, Legalpad, Diviner, Phriction. I'm not set on the exact language, just that there is consistency, feel free to suggest changes.

Test Plan

Test Legalpad, Diviner, Phriction.

pasted_file (351×436 px, 51 KB)

Diff Detail

Repository
rP Phabricator
Branch
phui-document-time
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5275
Build 5293: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 29727.Apr 13 2015, 12:09 AM
chad retitled this revision from to Add setEpoch for PHUIHeaderView, use in all Documents.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 13 2015, 12:09 AM
chad edited the test plan for this revision. (Show Details)Apr 13 2015, 12:09 AM
epriestley accepted this revision.Apr 13 2015, 12:38 AM
epriestley edited edge metadata.

Maybe "Updated Today", etc? I feel like it's not entirely obvious to just see, e.g., "<clock> Today".

This revision is now accepted and ready to land.Apr 13 2015, 12:38 AM
Closed by commit rP4ab9ebd9013a: Add setEpoch for PHUIHeaderView, use in all Documents (authored by chad, committed by chad). · Explain WhyApr 13 2015, 1:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diviner/
controller/
23 lines
legalpad/
controller/
3 lines
phriction/
controller/
14 lines
view/
phui/
15 lines

Diff 29727

View Options

src/applications/diviner/controller/DivinerBookController.php

Loading...
View Options

src/applications/legalpad/controller/LegalpadDocumentSignController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionDocumentController.php

Loading...
View Options

src/view/phui/PHUIHeaderView.php

Loading...
Phabricator · Built by Phacility