Page MenuHomePhabricator

Remove trivial implementations of getPagingColumn()
ClosedPublic

Authored by epriestley on Apr 12 2015, 2:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 9:46 AM
Unknown Object (File)
Mon, Dec 2, 5:17 AM
Unknown Object (File)
Mon, Dec 2, 5:17 AM
Unknown Object (File)
Mon, Dec 2, 5:17 AM
Unknown Object (File)
Mon, Dec 2, 5:05 AM
Unknown Object (File)
Mon, Nov 25, 6:11 AM
Unknown Object (File)
Oct 21 2024, 1:10 PM
Unknown Object (File)
Oct 20 2024, 8:12 PM
Subscribers

Details

Summary

Ref T7803. Some Query subclasses implement getPagingColumn() in a trivial way, usually to provide a table alias.

Formalize the concept of a primary table alias, and remove obsoleted getPagingColumn() implementations.

Test Plan

Issued affected queries.

Diff Detail

Repository
rP Phabricator
Branch
rpaging6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5238
Build 5256: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Remove trivial implementations of getPagingColumn().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 5:11 PM
This revision was automatically updated to reflect the committed changes.