Fix an issue where pastes could be reordered as a side effect of cache fills
ClosedPublic
Actions

Authored by epriestley on Apr 12 2015, 1:40 AM.

Details

Reviewers

Maniphest Tasks

T7803: Implement a composite query which unifies cursor paging across subqueries

Commits

Restricted Diffusion Commit
rPe6174ed45cbd: Fix an issue where pastes could be reordered as a side effect of cache fills

Summary

Ref T7803. Pastes which needed a cache fill would incorrectly be dropped to the bottom of the list. Stop doing that.

Test Plan

Loaded a list of pastes with some that needed cache fills, saw them appear in the correct order.

Diff Detail

Repository

rP Phabricator

Branch

rpaging4

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5236
Build 5254: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29676.Apr 12 2015, 1:40 AM

epriestley retitled this revision from to Fix an issue where pastes could be reordered as a side effect of cache fills.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7803: Implement a composite query which unifies cursor paging across subqueries.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 12 2015, 1:40 AM

btrahan accepted this revision.Apr 13 2015, 5:07 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 13 2015, 5:07 PM

Closed by commit rPe6174ed45cbd: Fix an issue where pastes could be reordered as a side effect of cache fills (authored by epriestley, committed by epriestley). · Explain WhyApr 13 2015, 7:00 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D12909: Filter pastes at the query level if we're unable to load their content.May 18 2015, 7:50 PM

epriestley mentioned this in rPb0862a81760d: Filter pastes at the query level if we're unable to load their content.May 18 2015, 8:57 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

paste/

query/

PhabricatorPasteQuery.php

10 lines

Diff 29676

View Options

src/applications/paste/query/PhabricatorPasteQuery.php

Fix an issue where pastes could be reordered as a side effect of cache fillsClosedPublicActions