Differential D12338

Conpherence - fix recent participant cache
ClosedPublic
Actions

Authored by btrahan on Apr 9 2015, 8:20 PM.

Tags

None

Referenced Files

	F14006702: D12338.id.diff
	Mon, Oct 28, 3:35 PM

	F13990732: D12338.id29645.diff
	Tue, Oct 22, 5:43 AM

	F13982632: D12338.diff
	Oct 20 2024, 12:47 AM

	F13974708: D12338.diff
	Oct 18 2024, 6:57 AM

	F13962868: D12338.id29643.diff
	Oct 15 2024, 12:43 PM

	F13956270: D12338.id29644.diff
	Oct 14 2024, 5:01 AM

	Unknown Object (File)
	Oct 3 2024, 3:53 PM

	Unknown Object (File)
	Oct 1 2024, 11:14 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T7795: UNRECOVERABLE FATAL ERROR <<< Call to a member function getName() when using Conpherence

Commits

Restricted Diffusion Commit
rP540e38d20e94: Conpherence - fix recent participant cache

Summary

Ref T7795. This fixes the behavior where you end up with a "a, b, c..." as the list of participants, and yet user a just left.

Test Plan

joined and left a thread. verified database had correct values. observed correct behavior in messages dropdown

Diff Detail

Repository

Branch

realT7795

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5215
Build 5233: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 29643.Apr 9 2015, 8:20 PM

btrahan retitled this revision from to Conpherence - fix recent participant cache.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

btrahan added a task: T7795: UNRECOVERABLE FATAL ERROR <<< Call to a member function getName() when using Conpherence.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 9 2015, 8:20 PM

epriestley added inline comments.Apr 9 2015, 8:22 PM

src/applications/conpherence/editor/ConpherenceEditor.php
262–265	I don't understand this -- shouldn't we still update the cache if a user leaves?

btrahan added inline comments.Apr 9 2015, 8:24 PM

src/applications/conpherence/editor/ConpherenceEditor.php
275	this function basically bumps the transaction author to the front, including adding them back if necessary. I can rename stuff so that's more clear.

Ah, okay. Yeah, that wasn't obvious to me.

This revision is now accepted and ready to land.Apr 9 2015, 8:25 PM

rename variable and function to the gist of 'make author most recent participant'

Closed by commit rP540e38d20e94: Conpherence - fix recent participant cache (authored by btrahan, committed by btrahan). · Explain WhyApr 9 2015, 9:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

editor/

ConpherenceEditor.php

24 lines

Diff 29643

src/applications/conpherence/editor/ConpherenceEditor.php

Loading...