Page MenuHomePhabricator
Differential D12305

Conpherence - don't lose title glyph when switching between messages
ClosedPublic
Actions

Authored by btrahan on Apr 6 2015, 6:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 8:06 AM
Unknown Object (File)
Tue, Dec 17, 1:50 AM
Unknown Object (File)
Fri, Dec 13, 10:07 PM
Unknown Object (File)
Tue, Dec 3, 4:37 PM
Unknown Object (File)
Mon, Dec 2, 4:28 PM
Unknown Object (File)
Mon, Dec 2, 8:06 AM
Unknown Object (File)
Mon, Dec 2, 8:06 AM
Unknown Object (File)
Mon, Dec 2, 8:06 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T7735: Conpherence threadData.title omits glyphs/names
Commits
Restricted Diffusion Commit
rP76d360740e17: Conpherence - don't lose title glyph when switching between messages
Summary

Fixes T7735

Test Plan

switched threads in main conpherence view and observed working title glyph.

Diff Detail

Repository
rP Phabricator
Branch
T7735
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5210
Build 5228: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 29547.Apr 6 2015, 6:26 PM
btrahan added a task: T7735: Conpherence threadData.title omits glyphs/names.
btrahan retitled this revision from to Conpherence - don't lose title glyph when switching between messages.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 6 2015, 6:26 PM
epriestley requested changes to this revision.Apr 8 2015, 7:20 PM
epriestley edited edge metadata.

I think this probably doesn't respect Settings → Display Preferences → Page Titles, but should.

This revision now requires changes to proceed.Apr 8 2015, 7:20 PM
epriestley added a comment.Apr 8 2015, 7:29 PM

(Some day we could maybe remove that setting, but I think Chrome on all OSes only recently started doing an OK job with Unicode, and AFAIK Windows is still a huge mess.)

btrahan updated this revision to Diff 29634.Apr 8 2015, 8:05 PM
btrahan edited edge metadata.

respect user preferences

wasn't too bad since we cache this data on the user object!

epriestley accepted this revision.Apr 8 2015, 8:45 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 8 2015, 8:45 PM
Closed by commit rP76d360740e17: Conpherence - don't lose title glyph when switching between messages (authored by btrahan, committed by btrahan). · Explain WhyApr 8 2015, 8:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
conpherence/
view/
10 lines

Diff 29634

View Options

src/applications/conpherence/view/ConpherenceThreadListView.php

Loading...
Phabricator · Built by Phacility