Page MenuHomePhabricator
Differential D12314

Add a very basic cache status page
ClosedPublic
Actions

Authored by epriestley on Apr 7 2015, 8:00 PM.
Tags
None
Referenced Files
F15474788: D12314.id29590.diff
Sun, Apr 6, 12:40 PM
F15474538: D12314.diff
Sun, Apr 6, 9:46 AM
F15474022: D12314.id29587.diff
Sun, Apr 6, 4:20 AM
F15473924: D12314.id29587.diff
Sun, Apr 6, 3:25 AM
F15473216: D12314.id29590.diff
Sat, Apr 5, 8:24 PM
F15465306: D12314.diff
Wed, Apr 2, 5:04 PM
F15398929: D12314.diff
Mon, Mar 17, 1:55 AM
F15367745: D12314.id29587.diff
Tue, Mar 11, 8:51 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T5501: Provide a builtin APC / OpCache diagnostics page and improve OpCache support
Commits
Restricted Diffusion Commit
rPc6b05dbb63a1: Add a very basic cache status page
Summary

Ref T5501. This is just getting version detection and availability right, probably.

Eventually, this will get lifted up a bit and "$remedy" will turn into setup issues (or maybe one setup issue saying "your cache setup is messed up, click here to understand why").

Test Plan

Screen_Shot_2015-04-07_at_12.57.38_PM.png (1×1 px, 222 KB)

I intend to shove these up to production one-by-one since production is APC and local is Opcache + APCu.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29587.Apr 7 2015, 8:00 PM
epriestley retitled this revision from to Add a very basic cache status page.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5501: Provide a builtin APC / OpCache diagnostics page and improve OpCache support.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 7 2015, 8:00 PM
btrahan accepted this revision.Apr 7 2015, 9:01 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/config/controller/PhabricatorConfigCacheController.php
7

handleRequest

This revision is now accepted and ready to land.Apr 7 2015, 9:01 PM
epriestley added a comment.Apr 7 2015, 9:22 PM

Oh, good call. I resurrected this from an old branch that predated the new hotness.

epriestley updated this revision to Diff 29590.Apr 7 2015, 9:27 PM
epriestley marked an inline comment as done.
epriestley edited edge metadata.
  • Modernize signature.
Closed by commit rPc6b05dbb63a1: Add a very basic cache status page (authored by epriestley, committed by epriestley). · Explain WhyApr 7 2015, 9:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
config/
application/
1 line
controller/
172 lines
2 lines

Diff 29591

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/config/application/PhabricatorConfigApplication.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigCacheController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigController.php

Loading...
Phabricator · Built by Phacility