Page MenuHomePhabricator
Differential D12311

Use different numbering schemes for nested ol's
ClosedPublic
Actions

Authored by • sshannin on Apr 7 2015, 2:19 PM.
Tags
Referenced Files
Unknown Object (File)
Wed, Dec 11, 8:25 PM
Unknown Object (File)
Tue, Dec 3, 11:35 AM
Unknown Object (File)
Sun, Dec 1, 12:43 AM
Unknown Object (File)
Thu, Nov 28, 2:18 PM
Unknown Object (File)
Oct 27 2024, 6:41 PM
Unknown Object (File)
Sep 10 2024, 12:59 PM
Unknown Object (File)
Sep 4 2024, 10:35 AM
Unknown Object (File)
Aug 27 2024, 1:27 PM
View All Files
Subscribers
epriestley

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7976: Nested ol's are hard to parse visually
Commits
Restricted Diffusion Commit
rP05b32e663471: Use different numbering schemes for nested ol's
Summary

Nested ol's using the same numbering scheme are hard to parse visually.

This just makes it a little nicer.

Maybe we could add greek too...

Test Plan

same.png (574×1 px, 45 KB)

different.png (570×1 px, 40 KB)

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5175
Build 5193: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

• sshannin updated this revision to Diff 29578.Apr 7 2015, 2:19 PM
• sshannin retitled this revision from to Use different numbering schemes for nested ol's.
• sshannin updated this object.
• sshannin edited the test plan for this revision. (Show Details)
• sshannin added a project: Remarkup.
Herald added reviewers: chad, Blessed Reviewers. · View Herald TranscriptApr 7 2015, 2:19 PM
Herald added a subscriber: epriestley. · View Herald Transcript
• sshannin mentioned this in T7976: Nested ol's are hard to parse visually.Apr 28 2015, 5:14 PM
• sshannin added a task: T7976: Nested ol's are hard to parse visually.
chad added a reviewer: epriestley.Apr 28 2015, 5:15 PM
chad edited edge metadata.

Seems fine to me, cc @epriestley.

You'll need to run celerity, bin/celerity map to generate a new CSS package.

• sshannin added a comment.Apr 28 2015, 5:20 PM

I didn't know what the procedure for that was. I noticed that sometimes you guys have exclusively veggie commits

epriestley accepted this revision.Apr 28 2015, 5:24 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 28 2015, 5:24 PM
Closed by commit rP05b32e663471: Use different numbering schemes for nested ol's (authored by • sshannin, committed by epriestley). · Explain WhyApr 28 2015, 5:25 PM
This revision was automatically updated to reflect the committed changes.
• sshannin added a comment.Apr 28 2015, 5:25 PM

Oh, I was about to update with map, but I'm slow ><

Revision Contents
Changeset List

PathSize
webroot/
rsrc/
css/
core/
14 lines

Diff 29578

View Options

webroot/rsrc/css/core/remarkup.css

Loading...
Phabricator · Built by Phacility