Differential D12265

Tune project hashtags a little more
ClosedPublic
Actions

Authored by epriestley on Apr 2 2015, 9:17 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T7738: Punctuation is parsed as part of #hashtags

Commits

Restricted Diffusion Commit
rPd8ab19a1662b: Tune project hashtags a little more

Summary

Fixes T7738. Improves handling of question marks and quotation marks.

Test Plan

Unit tests.

Diff Detail

Repository

rP Phabricator

Branch

projtag

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5106
Build 5124: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29459.Apr 2 2015, 9:17 PM

epriestley retitled this revision from to Tune project hashtags a little more.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7738: Punctuation is parsed as part of #hashtags.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 2 2015, 9:17 PM

More concise commenting.

btrahan accepted this revision.Apr 2 2015, 11:38 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 2 2015, 11:38 PM

Closed by commit rPd8ab19a1662b: Tune project hashtags a little more (authored by epriestley, committed by epriestley). · Explain WhyApr 3 2015, 11:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

remarkup/

ProjectRemarkupRule.php

21 lines

__tests__/

ProjectRemarkupRuleTestCase.php

30 lines

Diff 29459

View Options

src/applications/project/remarkup/ProjectRemarkupRule.php

View Options

src/applications/project/remarkup/tests/ProjectRemarkupRuleTestCase.php

Tune project hashtags a little moreClosedPublicActions