Don't show comment draft state to non-object-owners
ClosedPublic
Actions

Authored by epriestley on Apr 2 2015, 2:15 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T7720: Incorrect "Unsubmitted" state detection for Audit inline comments

Commits

Restricted Diffusion Commit
rP638cdb8d5773: Don't show comment draft state to non-object-owners

Summary

Fixes T7720. We currently leak the "draft" state of checkboxes; never treat checkboxes as drafts if you can't mark them.

Test Plan

Checked a box, reloaded page in other browser. Previously, the draft state partially propagated. Now, it no longer does.

Diff Detail

Repository

rP Phabricator

Branch

inline1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5102
Build 5120: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29448.Apr 2 2015, 2:15 PM

epriestley retitled this revision from to Don't show comment draft state to non-object-owners.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7720: Incorrect "Unsubmitted" state detection for Audit inline comments.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 2 2015, 2:15 PM

chad accepted this revision.Apr 2 2015, 2:16 PM

chad added a reviewer: chad.

This revision is now accepted and ready to land.Apr 2 2015, 2:16 PM

Closed by commit rP638cdb8d5773: Don't show comment draft state to non-object-owners (authored by epriestley, committed by epriestley). · Explain WhyApr 2 2015, 2:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

diff/

view/

PHUIDiffInlineCommentDetailView.php

6 lines

Diff 29448

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Don't show comment draft state to non-object-ownersClosedPublicActions