Page MenuHomePhabricator

Make file policies for emailed files more consistent
ClosedPublic

Authored by epriestley on Apr 2 2015, 2:15 AM.
Tags
None
Referenced Files
F17632325: D12255.id.diff
Thu, Jul 10, 2:48 PM
F17631882: D12255.id29437.diff
Thu, Jul 10, 2:12 PM
F17626939: D12255.id29455.diff
Thu, Jul 10, 5:25 AM
F17615513: D12255.diff
Wed, Jul 9, 2:07 PM
Unknown Object (File)
Sat, Jun 28, 2:43 PM
Unknown Object (File)
Sat, Jun 28, 1:06 PM
Unknown Object (File)
May 20 2025, 6:06 PM
Unknown Object (File)
May 9 2025, 2:10 PM
Subscribers

Details

Summary

Fixes T7712. Currently, files sent via email get default policies, like they were dragged and dropped onto the home page.

User expectation is better aligned with giving files more restrictive policies, like they were draggged and dropped directly onto an object.

Make files sent via email have restricted default visibility. Once we identify the sender, set them as the file author. Later, the file will become visible to other users via attachment to a task, revision, etc.

Test Plan

Sent some files via email; verified they got restrictive policies, correct authorship, and appropriate object attachment.

Diff Detail

Repository
rP Phabricator
Branch
fmail1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5094
Build 5112: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Make file policies for emailed files more consistent.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 2 2015, 7:54 PM
This revision was automatically updated to reflect the committed changes.